ATTENTION: Buglet in PHP 4.0b4p1
| From: | thies at digicol dot de | Date: | Thu, 24 Feb 2000 13:43:18 +0000 |
| Subject: | ATTENTION: Buglet in PHP 4.0b4p1 | ||
| Groups: | php.version4 | ||
| Request: | Send a blank email to php-version4+get-10832@lists.php.net to get a copy of this message | ||
everybody using 4.0b4p1
please apply the attached patch to configuration-parser.y to
avoid strange crashes.
expect 4.0b4p2 to be out later today!
tc
--
Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!"
Digital Collections Phone +49 40 235350 Fax +49 40 23535180
Hammerbrookstr. 93 20097 Hamburg / Germany
Index: php4/configuration-parser.y =================================================================== RCS file: /repository/php4/configuration-parser.y,v retrieving revision 1.35 retrieving revision 1.34 diff -u -r1.35 -r1.34 --- php4/configuration-parser.y 2000/02/24 13:39:36 1.35 +++ php4/configuration-parser.y 2000/02/19 23:21:25 1.34 @@ -19,7 +19,7 @@ -/* $Id: configuration-parser.y,v 1.35 2000/02/24 13:39:36 thies Exp $ */ +/* $Id: configuration-parser.y,v 1.34 2000/02/19 23:21:25 zeev Exp $ */ #define DEBUG_CFG_PARSER 0 #include "php.h" @@ -124,11 +124,12 @@ } -static void pvalue_config_destructor(zval *pvalue) +static void pvalue_config_destructor(zval **pvalue) { - if (pvalue->type == IS_STRING && pvalue->value.str.val != empty_string) { - free(pvalue->value.str.val); + if ((*pvalue)->type == IS_STRING && (*pvalue)->value.str.val != empty_string) { + free((*pvalue)->value.str.val); } + free(*pvalue); }
Index: php4/configuration-parser.y =================================================================== RCS file: /repository/php4/configuration-parser.y,v retrieving revision 1.35 retrieving revision 1.34 diff -u -r1.35 -r1.34 --- php4/configuration-parser.y 2000/02/24 13:39:36 1.35 +++ php4/configuration-parser.y 2000/02/19 23:21:25 1.34 @@ -19,7 +19,7 @@ -/* $Id: configuration-parser.y,v 1.35 2000/02/24 13:39:36 thies Exp $ */ +/* $Id: configuration-parser.y,v 1.34 2000/02/19 23:21:25 zeev Exp $ */ #define DEBUG_CFG_PARSER 0 #include "php.h" @@ -124,11 +124,12 @@ } -static void pvalue_config_destructor(zval *pvalue) +static void pvalue_config_destructor(zval **pvalue) { - if (pvalue->type == IS_STRING && pvalue->value.str.val != empty_string) { - free(pvalue->value.str.val); + if ((*pvalue)->type == IS_STRING && (*pvalue)->value.str.val != empty_string) { + free((*pvalue)->value.str.val); } + free(*pvalue); }