Re: [PHP4BETA] Patch to fix get_browser segmentation fault
| From: | Andi Gutmans | Date: | Sun, 27 Feb 2000 20:29:29 +0000 |
| Subject: | Re: [PHP4BETA] Patch to fix get_browser segmentation fault | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-11089@lists.php.net to get a copy of this message | ||
Thanks I applied your patch.
Andi
At 06:51 AM 2/25/00 -0500, Andreas Pour wrote:
Andreas Pour wrote: I tracked down the cause of the get_browser seg faults (bug number 3016). Patch file attached. Oops, wrong version, it's too early :-) . . . Correct one attached. Ciao, Andreas--- ext/standard/browscap.c.orig Sat Feb 19 18:41:20 2000--- Andi Gutmans <andi@zend.com> http://www.zend.com/+++ ext/standard/browscap.c Fri Feb 25 07:08:08 2000@@ -40,7 +40,7 @@ }; -static int browser_reg_compare(pval *browser) +static int browser_reg_compare(pval **browser) {pval *browser_name; regex_t r;@@ -48,7 +48,7 @@if (found_browser_entry) { /* already found */ return 0; } - zend_hash_find(browser->value.obj.properties, "browser_name_pattern",sizeof("browser_name_pattern"),(void **) &browser_name); + zend_hash_find((*browser)->value.obj.properties, "browser_name_pattern",sizeof("browser_name_pattern"),(void **) &browser_name); if (!strchr(browser_name->value.str.val,'*')) { return 0; }-- PHP 4.0 Beta Mailing List <http://www.php.net/version4/> To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net For additional commands, e-mail: php4beta-help@lists.php.net To contact the list administrators, e-mail: php4beta-admin@lists.php.net