Re: [PHP4BETA] [PATCH] unresolved externs in zend

Feel free to commit this patch... I generally think it might be best to have all of the Zend API functions inside extern c's, I can't see any drawbacks... Zeev At 02:10 06/03/2000 , rubys@us.ibm.com wrote:

I'm getting unresolved externals on zend_message_dispatcher. The following seems to fix it.

--- zend.c      2000/03/05 19:50:09     1.51
+++ zend.c      2000/03/05 23:58:17

@@ -466,12 +466,14 @@ } +BEGIN_EXTERN_C() ZEND_API void zend_message_dispatcher(long message, void *data) {

        if (zend_message_dispatcher_p) {
                zend_message_dispatcher_p(message, data);
        }

} +END_EXTERN_C() ZEND_API int zend_get_ini_entry(char *name, uint name_length, zval *contents) Index: zend.h =================================================================== RCS file: /repository/Zend/zend.h,v retrieving revision 1.77 diff -u -r1.77 zend.h

--- zend.h      2000/03/05 19:50:09     1.77
+++ zend.h      2000/03/05 23:58:18

@@ -298,7 +298,10 @@

 #define HANDLE_BLOCK_INTERRUPTIONS()           if

(zend_block_interruptions) { zend_block_interruptions(); }

 #define HANDLE_UNBLOCK_INTERRUPTIONS()         if

(zend_unblock_interruptions) { zend_unblock_interruptions(); } +BEGIN_EXTERN_C() ZEND_API void zend_message_dispatcher(long message, void *data); +END_EXTERN_C() + ZEND_API int zend_get_ini_entry(char *name, uint name_length, zval *contents); - Sam Ruby P.S. I used to have commit access to Zend...I no longer seem to. If this is intentional, OK; otherwise perhaps somebody should look into this? -- PHP 4.0 Beta Mailing List <http://www.php.net/version4/> To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net For additional commands, e-mail: php4beta-help@lists.php.net To contact the list administrators, e-mail: php4beta-admin@lists.php.net

-- Zeev Suraski <zeev@zend.com> http://www.zend.com/