Re: [PHP4BETA] cvs: /php4 fopen-wrappers.c

On Fri, Mar 31, 2000 at 01:19:05AM +0200, Andi Gutmans wrote: > I thought we agreed on Shane's approach. > I think it is better because there will be a tiny amount of places where we > will really call the real functions such as getcwd() (in SAPI.c) so it's > probably best not to confuse them and have unexpected behavior. > I was for redefining them in the beginning but then I agreed with Shane on > his approach. From your Email I understood you were also in favor of this > approach but I must have misread it. > Anyway, I do think this is the best way of doing it now. If you look at our CODING_STANDARDS, you will notice that they are completely outdated. What I fear is that new extension authors will join the PHP community without having any decent documentation. How shall they know that they must use PHP_CHDIR and friends in their code? In the future, there will be separate extensions distributed from various places which are not under our control. I think redefining chdir etc. to their virtual counterparts would proactively prevent broken code, and thus leveraging code quality. - Sascha