Re: [PHP4BETA] CVS update: php4/ext/standard
| From: | Sascha Schumann | Date: | Sun, 06 Jun 1999 11:16:19 +0000 |
| Subject: | Re: [PHP4BETA] CVS update: php4/ext/standard | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-1318@lists.php.net to get a copy of this message | ||
On Sun, Jun 06, 1999 at 06:28:26AM +0200, Andi Gutmans wrote:
> I don't have time to look at this code thoroughly right now but it seems
> there's a problem here. Unless you have a reason for doing this and I'm
> just not realizing it because I don't have time to look at the code now,
> you are changing variables to is_ref and increasing the reference count
> without doing extra work. However if your reference count is more than 1
> and the variable is not is_ref before you do this, you'll have to break
> away this variable from whatever other variables that are pointing at it.
> Let me know if this is the case, and I'll talk to Zeev about writing some
> API function. We wouldn't want you to implement this in each place
> yourself, it'd be better to have something general that will do the break
> away code as it exists already.
>
Yes, I tried to understand why my previous attempt of handling
variables in the session module did not work out. Having more
documentation about how is_ref/refcount play together would be
very helpful.
A dedicated API for this purpose would be cool, too.
--
Regards,
Sascha Schumann
Consultant