Re: [PHP4BETA] Debug flags don't propogate well

On Fri, 11 Jun 1999, Sascha Schumann wrote: > On Fri, Jun 11, 1999 at 03:13:33PM +0200, Sascha Schumann wrote: > > On Fri, Jun 11, 1999 at 03:59:35PM +0300, Zeev Suraski wrote: > > > > > > > > > Even when libzend and PHP are asked to be compiled with debug info inside > > > them, the flags don't propogate to libzend's CFLAGS, or to the CFLAGS of > > > the various extension modules (e.g. mysql.c). Those makefiles have > > > DEBUG_CFLAGS defined properly, but unlike the main PHP Makefile, it's not > > > appended to CFLAGS. > > > > > > Anybody? > > > > One should put the following line in all `Makefile.am's > > > > AM_CFLAGS = @DEBUG_CFLAGS@ > > > > At least that is my understanding of the discussion taking place > > on the automake mailing list. > > Or simply use a > > CFLAGS="$CFLAGS $DEBUG_CFLAGS" > > at the end of configure.in.in. I think we should avoid having to stuff all sorts of extra substitutions into the Makefile.am files. Each one of these makes the whole system a bit less maintainable. Just appending to CFLAGS is good IMHO. - Stig