Re: [PHP4BETA] cvs: php4 /ext/session/ session.c
| From: | Andi Gutmans | Date: | Mon, 15 May 2000 15:15:06 +0000 |
| Subject: | Re: [PHP4BETA] cvs: php4 /ext/session/ session.c | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-15049@lists.php.net to get a copy of this message | ||
strchr is faster than memchr.
Andi
On Mon, 15 May 2000, Sascha Schumann wrote:
> sas Mon May 15 11:55:03 2000 EDT
>
> Modified files:
> /php4/ext/session session.c
> Log:
> Drop slower strchr in favor of memchr.
>
>
> Index: php4/ext/session/session.c
> diff -u php4/ext/session/session.c:1.135 php4/ext/session/session.c:1.136
> --- php4/ext/session/session.c:1.135 Thu May 4 22:29:36 2000
> +++ php4/ext/session/session.c Mon May 15 11:55:03 2000
> @@ -249,7 +249,7 @@
> int has_value;
>
> current = (zval *) ecalloc(sizeof(zval), 1);
> - for (p = q = val; (p < endptr) && (q = strchr(p, '|')); p = q) {
> + for (p = q = val; (p < endptr) && (q = memchr(p, '|', endptr - p)); p =
> q) {
> if (p[0] == '!') {
> p++;
> has_value = 0;
>
>
>
>