Re: [PHP4BETA] cvs: php4 / main.c

On Sun, 28 May 2000 thies@digicol.de wrote: > On Sun, May 28, 2000 at 08:09:20PM +0300, Andi Gutmans wrote: > > Actually, zend_activate_modules() should be moved after the phpinfo() and > > friends functionality. The only reason why I moved them back was because > > it was right before the 4.0.0 release and I didn't want to break anything. > > I don't think those functions need zend_activate_modules() to be called > > unless their info() functions use information which is per-request. It > > really needs to be checked. > > hmm, but there's no need to optimize the speed of phpinfo() - > right? why not move the > zend_activate_modules()/zend_deactivate_modules() outside > around php_execute_script()? Because php_execute_script() is called from a few places and therefore the activation of modules should just be in one place. I'll change it and we'll see if it breaks anything. Andi