Re: [PHP4BETA] cvs: php4 /ext/standard/ basic_functions.c basic_functions.h php_noavail.c php_noavail.h
| From: | Andi Gutmans | Date: | Mon, 29 May 2000 17:08:16 +0000 |
| Subject: | Re: [PHP4BETA] cvs: php4 /ext/standard/ basic_functions.c basic_functions.h php_noavail.c php_noavail.h | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-15913@lists.php.net to get a copy of this message | ||
I think the prototype could go into php.h near the definitions of PHP_FE()
and friends.
What I would like to have in future is moving that to php_API.h. I think a
seperation between php.h and php_API.h would be better.
Andi
On Mon, 29 May 2000, Hartmut Holzgraefe wrote:
> Zeev Suraski wrote:
> >
> > zeev Mon May 29 09:13:38 2000 EDT
> >
> > Removed files:
> > /php4/ext/standard php_noavail.c php_noavail.h
> >
> > Modified files:
> > /php4/ext/standard basic_functions.c basic_functions.h
> > Log:
> > There's really no need for an entire file for a one line function...
>
> the reasons for putting in php_noavail.[ch] where
>
> 1) the mechanism behind warn_not_available() is not limit to
> php4/ext/standard
> so i wasn't sure it should be in php4/ext/standard or in php4/
>
> puttig the implementation in a file of its own allows moving it
> somewhere
> else without trouble
>
> 2) the prototype for warn_not_available() is needed by other modules
> (especially ext/imap) that i didn't check in yet
> that's what the .h file and it's inclusion into php.h was for
>
> removing this does still work in the repository as of now but breaks
> some other modules i didn't check in yet that make use of
>
> PHP_ALIAS(some_function_not_available_for_some_reason,warn_not_available,NULL)
>
> :(
>
>
>
> > + PHP_FE(warn_not_available, NULL)
>
> warn_not_available is for internal use in alias entries for functions
> not available and should not be visible to the user
> (as it does not provide any functionality suitable for userspace)
>
>
> --
> Hartmut Holzgraefe hartmut@six.de
> http://www.six.de
>
>