[PHP4BETA] Re: [PHP-DEV] Re: [PHP4BETA] CVS update: php4

On Wed, Apr 21, 1999 at 09:34:25PM +0300, Zeev Suraski wrote: > As it broke PHP 3.0.7-dev under Windows, it broke PHP 4.0 as well... Well, if it breaks the compilation, why not simply fix it? > php_compat.h is only necessary for flock, if I'm not mistaken. and inet_ntoa() > In that case, please include it only where it's really necessary, and also > name it appropriately. Right now, including that file from php.h kills > Win32 compilations. Suggestion for a new name? > Also, in general, I want to try and avoid including files in php.h unless > they're really used by all of PHP. This should make dependencies much > more reasonable and recompile times much shorter. Yeah, but in general, compatible routines don't change that often and if they change, they affect everything. Since it should be transparent to the rest of PHP, if it uses a function provided by a system library or our php_compat, it should not be necessary to include extra files. -- Regards, Sascha Schumann | Consultant | finger sas@schell.de | for PGP public key -- PHP 4 Beta