Re: [PHP4BETA] IMAP

At 06:31 AM 7/31/99 , Zeev Suraski wrote: >At 07:54 31/07/99 , Dustin Marquess wrote: >>At 06:36 PM 7/30/99 , Zeev Suraski wrote: >> >zeev Fri Jul 30 19:36:21 1999 EDT >> > >> > Modified files: >> > /php4/ext/imap imap.c >> > Log: >> > Ok, that should be a good start. Can somebody verify that this actually >> >compiles, >> > and perhaps check if it runs? >> >> The only thing keeping it from compiling is the fact tha the >> prototype and >>the declaration for add_assoc_object() don't match. The prototype is >>designed with tmp being a pointer to pval and the declaration is defined >>with tmp being a pval. Changing the declaration to match the prototype >>allowed it to compile. >> >> On the downside, php3_imap_headerinfo() still seems to be messing-up. >> >>[Sat Jul 31 00:55:53 1999] [notice] child pid 9604 exit signal Illegal >>instruction (4) > >Well, the way gcc may have resolved the declaration conflict may have had >something to do with it... >I fixed it, please try it now. Rock on... that fix you just put into the CVS tree fixed the problem... I only problem that I had left as the Cc: parser, which the attached patch fixes.... Bugs #1804 and #1839 should be fixed with your new changes. Thanks alot man... -Dustin

*** ext/imap/imap.c.old Sat Jul 31 18:48:02 1999 --- ext/imap/imap.c Sat Jul 31 19:13:39 1999 *************** *** 1279,1288 **** do { MAKE_STD_ZVAL(ccvals); object_init(ccvals); ! if(addresstmp->personal) add_property_string( &ccvals, "personal", addresstmp->personal, 1); ! if(addresstmp->adl) add_property_string( &ccvals, "adl", addresstmp->adl, 1); ! if(addresstmp->mailbox) add_property_string( &ccvals, "mailbox", addresstmp->mailbox, 1); ! if(addresstmp->host) add_property_string( &ccvals, "host", addresstmp->host, 1); add_next_index_object(cc, ccvals); } while ( (addresstmp = addresstmp->next) ); add_assoc_object(return_value, "cc", cc); --- 1279,1288 ---- do { MAKE_STD_ZVAL(ccvals); object_init(ccvals); ! if(addresstmp->personal) add_property_string(ccvals, "personal", addresstmp->personal, 1); ! if(addresstmp->adl) add_property_string(ccvals, "adl", addresstmp->adl, 1); ! if(addresstmp->mailbox) add_property_string(ccvals, "mailbox", addresstmp->mailbox, 1); ! if(addresstmp->host) add_property_string(ccvals, "host", addresstmp->host, 1); add_next_index_object(cc, ccvals); } while ( (addresstmp = addresstmp->next) ); add_assoc_object(return_value, "cc", cc);