Re: [PHP4BETA] ZTS stuff in main.c

At 10:40 PM 8/18/99 +0200, Thies C. Arntzen wrote:

1st resource gets allocated (sapi_globals) id is 0 - php_module_startup gets called and does a ELS_FETCH() executor_globals_id is still 0 (inited by the compiler) and the ELS_FETCH() loads the sapi_globals into executor_globals - few lines later (still in php_module_startup and *before* we call zend_startup - which would create the *real* executor_globals) we do a EG(error_reporting) = E_ALL & ~E_NOTICE; which writes into our sapi_globals -> which is wrong. please correct me if i'm wrong,

You seem to be right. The ELS_FETCH there is before executor_globals_id is initialized. The only question remains, if error_reporting is used by zend_startup(). If not, it can be moved to after the call to zend_startup(). If it is needed it might need to go into zend_startup(). Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/