Re: [PHP4BETA] fd-leak in libzend NOT is closed!
| From: | Thies C. Arntzen | Date: | Fri, 03 Dec 1999 09:59:17 +0000 |
| Subject: | Re: [PHP4BETA] fd-leak in libzend NOT is closed! | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-7310@lists.php.net to get a copy of this message | ||
On Thu, 2 Dec 1999 zeev@zend.com wrote:
> It doesn't look right, that is, the entire situation isn't supposed to
> happen (ZEND_HANDLE_FILENAME are never supposed to be closed, the .fp
> property isn't supposed to be valid). Can you send us a test case?
zeev, andi
just found out the the problem is still not fixed.
the fix i made closes all included files at the *END* of the script, but a
include should get closed as soon as it has been compiled.
from zend-scanner.l
if (open_file_for_scanning(file_handle CLS_CC)==FAILURE) {
zend_message_dispatcher(ZMSG_FAILED_INCLUDE_FOPEN, file_handle->filename);
} else {
CG(active_op_array) = op_array;
compiler_result = zendparse(CLS_C);
zend_close_file_handle(file_handle CLS_CC);
when using include "":
open_file_for_scanning created a new FILE* but zend_close_file_handle()
will *NOT* close it.
please have a look at this.
regards,
tc
>
> Zeev
>
> On Thu, 2 Dec 1999, Thies C. Arntzen wrote:
>
> > not sure if this is the way we want it though?!
> >
> > tc
> >
> >
> >
>
>
>
Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!"
Digital Collections Phone +49 40 235350 Fax +49 40 23535180
Hammerbrookstr. 93 20097 Hamburg / Germany