Re: [PHP4BETA] cvs: /php4 php4dllts.dsp /php4/ext/standard assert.c
| From: | Thies C. Arntzen | Date: | Tue, 07 Dec 1999 16:48:57 +0000 |
| Subject: | Re: [PHP4BETA] cvs: /php4 php4dllts.dsp /php4/ext/standard assert.c | ||
| References: | 1 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-7621@lists.php.net to get a copy of this message | ||
On Tue, 7 Dec 1999, Sascha Schumann wrote:
> On Tue, Dec 07, 1999 at 04:28:58PM -0000, Sam Ruby wrote:
> > rubys Tue Dec 7 11:28:58 1999 EDT
> >
> > Modified files:
> > /php4 php4dllts.dsp
> > /php4/ext/standard assert.c
> > Log:
> > fixed just enough to enable assert to build on win32 and Linux/ZTS
> >
> > Index: php4/php4dllts.dsp
> > diff -u php4/php4dllts.dsp:1.38 php4/php4dllts.dsp:1.39
> > --- php4/php4dllts.dsp:1.38 Sat Dec 4 18:53:08 1999
> > +++ php4/php4dllts.dsp Tue Dec 7 11:28:26 1999
> > @@ -279,6 +279,10 @@
> > # End Source File
> > # Begin Source File
> >
> > +SOURCE=.\ext\standard\assert.c
> > +# End Source File
> > +# Begin Source File
> > +
> > SOURCE=.\ext\standard\base64.c
> > # End Source File
> > # Begin Source File
> > Index: php4/ext/standard/assert.c
> > diff -u php4/ext/standard/assert.c:1.4 php4/ext/standard/assert.c:1.5
> > --- php4/ext/standard/assert.c:1.4 Tue Dec 7 08:33:37 1999
> > +++ php4/ext/standard/assert.c Tue Dec 7 11:28:27 1999
> > @@ -16,7 +16,7 @@
> > +----------------------------------------------------------------------+
> > */
> >
> > -/* $Id: assert.c,v 1.4 1999/12/07 13:33:37 thies Exp $ */
> > +/* $Id: assert.c,v 1.5 1999/12/07 16:28:27 rubys Exp $ */
> >
> > /* {{{ includes/startup/misc */
> >
> > @@ -82,10 +82,15 @@
> > PHP_INI_ENTRY("assert.callback", NULL, PHP_INI_ALL, NULL)
> > PHP_INI_END()
> >
> > +static void php_assert_init_globals(php_assert_globals *assert_globals)
> > +{
> > +}
> > +
> > PHP_MINIT_FUNCTION(assert)
> > {
> >
> > #ifdef ZTS
> > + ELS_FETCH();
> > assert_globals_id = ts_allocate_id(sizeof(php_assert_globals), (ts_allocate_ctor)
> > php_assert_init_globals, NULL);
> > #endif
>
> An empty constructor does not look useful to me.. why is it
> there? If it is not needed, please remove the reference from
> ts_allocate_id().
>
module is still growing - will reomve it when it is stableized & not
needed.
tc
> --
>
> Regards,
>
> Sascha Schumann
> Consultant
>
> --
> PHP 4.0 Beta Mailing List <http://www.php.net/version4/>
> To unsubscribe, e-mail: php4beta-unsubscribe@lists.php.net
> For additional commands, e-mail: php4beta-help@lists.php.net
> To contact the list administrators, e-mail: php4beta-admin@lists.php.net
>
>
Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!"
Digital Collections Phone +49 40 235350 Fax +49 40 23535180
Hammerbrookstr. 93 20097 Hamburg / Germany