Re: svn: /web/php/trunk/ include/header.inc js/common.js js/jquery.autocomplete.js js/jquery.autocomplete.pack.js styles/structure.css
styles/theme.css
| From: | Hannes Magnusson | Date: | Thu, 30 Dec 2010 20:13:12 +0000 |
| Subject: | Re: svn: /web/php/trunk/ include/header.inc js/common.js js/jquery.autocomplete.js js/jquery.autocomplete.pack.js styles/structure.css styles/theme.css |
||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-10038@lists.php.net to get a copy of this message | ||
On Thu, Dec 30, 2010 at 20:50, Paul Dragoonis <dragoonis@gmail.com> wrote:
> On Thu, Dec 30, 2010 at 7:18 PM, Stewart Lord <stewey@ambitious.ca> wrote:
>>
>> On 2010-12-30, at 3:51 AM, Paul Dragoonis wrote:
>>
>>> Hey Stewart,
>>>
>>> The documentation dropdown looks really nice, but it's currently
>>> broken in 2 parts.
>>> First one is that you have to click twice on it, which i'm looking to fix.
>>> Secondly, if you click the dropdown button about 5 times really
>>> quickly the page completely screws up.
>>> My prediction is that because you're using appendTo() every time you
>>> click the button, this is a big DOM change, and the DOM gets confused
>>> and backs out of what it's doing.
>>> So i'm going to change the implementation so that there are 0 DOM
>>> movement changes needed and just a show/hide of content, this will
>>> allow for a snappier response and less DOM work.
>>>
>>> Ping me an email back if you have started doing changes on the
>>> Documentation dropdown since your last commit.
>>>
>>> Cheers.
>>> Paul.
>>
>>
>> Hi Paul, any help on this would be appreciated. I was going to fix it, but if you can
>> tackle it then I'll start looking at the home page design.
>>
>> Cheers,
>> Stew
>
>
> "Committed revision 306878." - We now have TOC working as mentioned.
> "svn up" and go to the 'strpos' page or something and give it a go,
> comments appreciated.
>
The effect is pretty.. but it broke the actual anchors.. I can no
longer right-click the link and do 'copy link location' or open in new
tab :( (making it therefore harder to share direct links..).
Don't know if thats an issue... if you mouse over the header, slightly
to the right, you can get a direct link..
I wonder if clicking those should use scrollTo() to?
-Hannes