Re: svn: /web/php/trunk/ include/header.inc styles/home.css
| From: | Hannes Magnusson | Date: | Sat, 08 Jan 2011 18:26:13 +0000 |
| Subject: | Re: svn: /web/php/trunk/ include/header.inc styles/home.css | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-10341@lists.php.net to get a copy of this message | ||
On Sat, Jan 8, 2011 at 19:15, Paul Dragoonis <dragoonis@php.net> wrote:
> dragoonis                 Sat, 08 Jan 2011 18:15:46 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=307273
>
> Log:
> Changes to the homepage downloads area: Now we have a link to the gz, bz2 and the windows
> section for each release
>
> Changed paths:
> Â Â U Â web/php/trunk/include/header.inc
> Â Â U Â web/php/trunk/styles/home.css
>
> Modified: web/php/trunk/include/header.inc
> ===================================================================
> --- web/php/trunk/include/header.inc   2011-01-08 17:24:36 UTC (rev 307272)
> +++ web/php/trunk/include/header.inc   2011-01-08 18:15:46 UTC (rev 307273)
> @@ -85,7 +85,6 @@
> Â Â </span>
> Â </div>
> Â </div>
> -
> Â <nav id="headnav">
>
> Â <ul id="headmenu">
> @@ -113,20 +112,26 @@
> Â Â Â Â Â Â <p class="tutorial"><a
> href="/tut.php">Introductory Tutorial »</a></p>
> Â Â Â Â </div>
> Â Â Â Â <div class="download">
> -<?php foreach ($RELEASES[5] as $version => $release): ?>
> - Â Â Â Â Â Â <a href="/get/<?php echo
> $release['source'][0]['filename'] ?>/from/a/mirror">
> - Â Â Â Â Â Â Â Â <span class="version">PHP <?php echo $version
> ?></span>
> - Â Â Â Â Â Â Â Â <span class="package">Complete Source
> Code</span>
> - Â Â Â Â Â Â Â Â <span class="file">
> - Â Â Â Â Â Â Â Â Â Â <?php echo
> $release['source'][0]['filename'] ?>
> - Â Â Â Â Â Â Â Â Â Â <!-- (size) should go here, but it's not in version.inc
> at present -->
> - Â Â Â Â Â Â Â Â </span>
> - Â Â Â Â Â Â </a>
> -<?php endforeach; ?>
> -       <a href="¥‹T¡{y
> ]:ŽÙÄ´ë )http://windows.php.net" class="windows">
> - Â Â Â Â Â Â Â Â <span class="version">Windows Downloads</span>
> - Â Â Â Â Â Â Â Â <span
> class="date">http://windows.php.net/</span>
> - Â Â Â Â Â Â </a>
> +<?php if(!empty($RELEASES[5])): ?>
> + Â Â Â Â Â Â Â <ul>
> + Â Â Â <?php
> + Â Â Â foreach ($RELEASES[5] as $version => $release):
> + Â Â Â Â Â Â Â $windowsVersionLink = substr($version, 0, strrpos($version,
> '.'));
> + Â Â Â ?>
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â <li>
> + Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="/get/<?php echo
> $release['source'][1]['filename'] ?>/from/a/mirror"
> class="version">PHP <?php echo $version ?></a>
> + Â Â Â Â Â Â Â Â Â Â Â Â Â <a href="/get/<?php echo
> $release['source'][0]['filename'] ?>/from/a/mirror">Download as
> bz2</a>
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â <a
> href="http://windows.php.net/download/#php-<?php echo
> $windowsVersionLink; ?>">Download for windows</a>
> + Â Â Â Â Â Â Â Â Â Â Â Â Â <!-- (size) should go here, but it's not in
> version.inc at present -->
Whats the dealio with WS here, and why don't you use download_link()?
This feels a bit awkward. How about "Other types: [bz2] | [Windows]"
or something like that?
> + Â Â Â Â Â Â Â Â Â Â Â </li>
> + Â Â Â <?php endforeach; ?>
> +
> + Â Â Â Â Â Â Â Â Â <li class="windows">
> + Â Â Â Â Â Â Â Â Â Â Â <a
> href="http://windows.php.net/"
> title="">Download for windowss</a>
> + Â Â Â Â Â Â Â Â Â Â Â <a
> href="http://windows.php.net/"
> title=>http://windows.php.net/</a>
> + Â Â Â Â Â Â Â Â Â </li>
> + Â Â Â Â Â Â Â </ul>
That should be removed since the windows links are already in the
others. The various markup errors and typos atleast fixed.
-Hannes