Re: svn: /web/php/trunk/ svn-php.php
| From: | Hannes Magnusson | Date: | Thu, 09 Jun 2011 14:30:42 +0000 |
| Subject: | Re: svn: /web/php/trunk/ svn-php.php | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-11164@lists.php.net to get a copy of this message | ||
On Thu, Jun 9, 2011 at 16:10, Philip Olson <philip@php.net> wrote:
> philip Thu, 09 Jun 2011 14:10:38 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=311976
>
> Log:
> Added requirement to choose a group. Defaults to 'Choose One'
>
> Changed paths:
> U web/php/trunk/svn-php.php
>
> Modified: web/php/trunk/svn-php.php
> ===================================================================
> --- web/php/trunk/svn-php.php 2011-06-09 13:09:25 UTC (rev 311975)
> +++ web/php/trunk/svn-php.php 2011-06-09 14:10:38 UTC (rev 311976)
> @@ -23,6 +23,7 @@
> site_header("Using SVN for PHP Development", array("current" =>
> "FIXME"));
>
> $groups = array(
> + "none" => "Choose One",
> "php" => "PHP Group",
> "pear" => "PEAR Group",
> "pecl" => "PECL Group",
> @@ -72,7 +73,7 @@
> if (empty($_POST['yesno']) || $_POST['yesno'] != 'yes') {
> $error .= "You did not fill the form out correctly. <br />";
> }
> - if (empty($_POST['group']) || !isset($groups[$_POST['group']])) {
> + if (empty($_POST['group']) || $_POST['group'] === 'none'
> || !isset($groups[$_POST['group']])) {
shouldn't it be the other way around; !isset() || == none ?
-Hannes