Re: svn: /web/php-bugs/trunk/include/ functions.php
| From: | Hannes Magnusson | Date: | Fri, 01 Jul 2011 07:22:15 +0000 |
| Subject: | Re: svn: /web/php-bugs/trunk/include/ functions.php | ||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-11416@lists.php.net to get a copy of this message | ||
On Fri, Jul 1, 2011 at 09:20, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Fri, Jul 1, 2011 at 01:03, Felipe Pena <felipe@php.net> wrote:
>> felipe Thu, 30 Jun 2011 23:03:02 +0000
>>
>> Revision:
>> http://svn.php.net/viewvc?view=revision&revision=312742
>>
>> Log:
>> - Ok, the initial mail on creating the report is sent to sec@, fixing the mail when adding
>> comments
>
> Waiit... Really? Did you fix it?
>
>> + $params = '';
>
> Shouldn't this default to -fnoreply@?
> Passing that argument as empty will overwrite the expected default
> value in the function declaration...
Bleh. See it now, you modified it again.
But wouldn't it be easier to simply set the variable to -fnoreply here? :)
-Hannes