Re: svn: /web/php-bugs/trunk/www/js/ userlisting.php

I believe that it was already broken. This script printed the empty string which have caused a JS error in search.js which requires the 'lookup' variable. I just fixed this JS error. Jakub Vrána > I think you broke it.. > I no longer get any autocmplete whatsoever when trying to assign a > report to another user... > -Hannes > On Fri, Jul 1, 2011 at 15:35, Jakub Vrana <vrana@php.net> wrote: >> vrana                                    Fri, 01 Jul 2011 13:35:04 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=312766 >> >> Log: >> Avoid JS error >> >> Changed paths: >>    U   web/php-bugs/trunk/www/js/userlisting.php >> >> Modified: web/php-bugs/trunk/www/js/userlisting.php >> =================================================================== >> --- web/php-bugs/trunk/www/js/userlisting.php   2011-07-01 12:22:27 UTC (rev 312765) >> +++ web/php-bugs/trunk/www/js/userlisting.php   2011-07-01 13:35:04 UTC (rev 312766) >> @@ -36,10 +36,6 @@ >>  } >>  $modified = apc_fetch('svnusers_update'); >> >> -if (!$json) { >> -       return; >> -} >> - >>  $tsstring = gmdate('D, d M Y H:i:s ', $modified); >>  if (isset($_SERVER['HTTP_IF_MODIFIED_SINCE']) && >> $_SERVER['HTTP_IF_MODIFIED_SINCE'] == $tsstring) { >>        header('HTTP/1.1 304 Not Modified'); >> @@ -52,18 +48,20 @@ >> >>  $lookup = $user = array(); >> >> -foreach ($json as $row) { >> -       $lookup[] = $row['name']; >> -       $lookup[] = $row['username']; >> - >> -       $data = array( >> -               'email'         => md5($row['username'] . >> '@php.net'), >> -               'name'          => $row['name'], >> -               'username'      => $row['username'], >> -       ); >> - >> -       $user[$row['username']] = $data; >> -       $user[$row['name']]             = $data; >> +if ($json) { >> +       foreach ($json as $row) { >> +               $lookup[] = $row['name']; >> +               $lookup[] = $row['username']; >> + >> +               $data = array( >> +                       'email'         => >> md5($row['username'] . '@php.net'), >> +                       'name'          => >> $row['name'], >> +                       'username'      => >> $row['username'], >> +               ); >> + >> +               $user[$row['username']] = $data; >> +               $user[$row['name']]             = $data; >> +       } >>  } >> >>  echo 'var users = ', json_encode($user), ";\n", >> >> >> -- >> PHP Webmaster List Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >>