svn: /web/php/trunk/ quickref.php

philip Tue, 19 Jul 2011 23:16:41 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=313459 Log: notfound is already escaped inside manual-lookup.php, so it was escaped twice. Bug discovered by Chris Jones Changed paths: U web/php/trunk/quickref.php Modified: web/php/trunk/quickref.php =================================================================== --- web/php/trunk/quickref.php 2011-07-19 23:06:18 UTC (rev 313458) +++ web/php/trunk/quickref.php 2011-07-19 23:16:41 UTC (rev 313459) @@ -131,11 +131,11 @@ site_header("Manual Quick Reference", $head_options+array("current" => "docs")); -$notfound_sc = htmlspecialchars($notfound, ENT_QUOTES, 'UTF-8'); -$notfound_enc = urlencode($notfound_sc); +// Note: $notfound is defined (with htmlspecialchars) inside manual-lookup.php +$notfound_enc = urlencode($notfound); if ($snippet = is_known_snippet($notfound)) { - echo "<h1>Related snippet found for '{$notfound_sc}'</h1>"; + echo "<h1>Related snippet found for '{$notfound}'</h1>"; echo "<p>{$snippet}</p>"; } ?> @@ -145,7 +145,7 @@ <?php if (!empty($notfound) && count($maybe) > 0) { ?> <p> - <b><?php echo $notfound_sc; ?></b> doesn't exist. Closest matches: + <b><?php echo $notfound; ?></b> doesn't exist. Closest matches: </p> <?php quickref_table($maybe, false); ?> @@ -172,7 +172,7 @@ <h1>Other forms of search</h1> <p> -To search the string "<b><?php echo $notfound_sc; ?></b>" using other options, try searching: +To search the string "<b><?php echo $notfound; ?></b>" using other options, try searching: </p> <ul>