svn: /web/php-gcov/trunk/ cron/compile_results.php www/compile_results.php www/params.php www/site.api.php

felipe Sat, 23 Jul 2011 15:10:47 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=313634 Log: - Let format this mail better... And adding opengrok link Changed paths: U web/php-gcov/trunk/cron/compile_results.php U web/php-gcov/trunk/www/compile_results.php U web/php-gcov/trunk/www/params.php U web/php-gcov/trunk/www/site.api.php Modified: web/php-gcov/trunk/cron/compile_results.php =================================================================== --- web/php-gcov/trunk/cron/compile_results.php 2011-07-23 14:26:09 UTC (rev 313633) +++ web/php-gcov/trunk/cron/compile_results.php 2011-07-23 15:10:47 UTC (rev 313634) @@ -89,13 +89,22 @@ $mail_message .= sprintf(">>> File: %s\n", $path); foreach ($fileentry as $entry) { - $mail_message .= vsprintf("Function: %s:%d (%s)\n", $entry); + $mail_message .= sprintf("Function: %s:%d %s (%s)\n", + $entry[0], + $entry[1], + make_lxr_link($phpver, $path, $entry[1]), + $entry[2]); } + $mail_message .= "\n\n"; } + $headers = "MIME-Version: 1.0\n"; + $headers .= "Content-type: text/html; charset=iso-8859-1\n"; + $headers .= "From: PHP GCOV <php-qa@lists.php.net>"; + mail('php-qa@lists.php.net', - sprintf('[PHP-GCOV] Build error - %s', $phpver), + sprintf('[PHP-GCOV] Build error - %s (%s)', $phpver, date('Y-m-d')), $mail_message, - 'From: PHP GCOV <php-qa@lists.php.net>', + $headers, '-f noreply@php.net'); -} \ No newline at end of file +} Modified: web/php-gcov/trunk/www/compile_results.php =================================================================== --- web/php-gcov/trunk/www/compile_results.php 2011-07-23 14:26:09 UTC (rev 313633) +++ web/php-gcov/trunk/www/compile_results.php 2011-07-23 15:10:47 UTC (rev 313634) @@ -56,7 +56,7 @@ $line = htmlspecialchars($entry[1]); $type = $entry[2]; $msg = htmlspecialchars($entry[3]); - $lxrlink = make_lxr_link($path, $line); + $lxrlink = make_lxr_link($version, $path, $line); $cvslink = make_cvs_link($path, $line); $funclink = make_lxr_func_link($function); $pretty_type = make_error_highlight($type); Modified: web/php-gcov/trunk/www/params.php =================================================================== --- web/php-gcov/trunk/www/params.php 2011-07-23 14:26:09 UTC (rev 313633) +++ web/php-gcov/trunk/www/params.php 2011-07-23 15:10:47 UTC (rev 313634) @@ -54,7 +54,7 @@ $line = htmlspecialchars($entry[0]); $function = htmlspecialchars($entry[1]); $msg = htmlspecialchars($entry[2]); - $lxrlink = make_lxr_link($path, $line); + $lxrlink = make_lxr_link($version, $path, $line); $cvslink = make_cvs_link($path, $line); ++$total; Modified: web/php-gcov/trunk/www/site.api.php =================================================================== --- web/php-gcov/trunk/www/site.api.php 2011-07-23 14:26:09 UTC (rev 313633) +++ web/php-gcov/trunk/www/site.api.php 2011-07-23 15:10:47 UTC (rev 313634) @@ -300,14 +300,13 @@ } // Hacked for our change to OpenGrok -function make_lxr_link($path, $line) +function make_lxr_link($version, $path, $line) { if ($path{0} === '/') { return ''; } - $version = $GLOBALS['version']; - if ($GLOBALS['version'] === 'PHP_HEAD') { + if ($version === 'PHP_HEAD') { $version = 'PHP_TRUNK'; }