Re: svn: /web/php-gcov/trunk/cron/ cron.sh

On Sat, Jul 23, 2011 at 20:09, Nuno Lopes <nlopess@php.net> wrote: >> On Sat, Jul 23, 2011 at 16:26, Nuno Lopes <nlopess@php.net> wrote: >>> >>> nlopess Sat, 23 Jul 2011 14:26:09 +0000 >>> >>> Revision: >>> http://svn.php.net/viewvc?view=revision&revision=313633 >>> >>> Log: >>> quick hack to run buildconf with autoconf 2.13 on php 5.3 >>> >>> Changed paths: >>> U web/php-gcov/trunk/cron/cron.sh >>> >>> Modified: web/php-gcov/trunk/cron/cron.sh >>> =================================================================== >>> --- web/php-gcov/trunk/cron/cron.sh 2011-07-23 13:48:07 UTC (rev 313632) >>> +++ web/php-gcov/trunk/cron/cron.sh 2011-07-23 14:26:09 UTC (rev 313633) >>> @@ -109,8 +109,13 @@ >>> cd ${PHPTAG} >>> fi >>> ./vcsclean >>> - ./buildconf --force > /dev/null >>> >>> + if [ "${PHPTAG}" = "PHP_5_3" ]; then >>> + PHP_AUTOCONF=autoconf-2.13 ./buildconf --force > /dev/null >>> + else >>> + ./buildconf --force > /dev/null >>> + fi >> >> buildconf wont actually be executed there for 5.3.. you only set the >> PHP_AUTOCONF variable to a command line.. > > Actually no. That syntax means that the variable is only defined for the > scope of execution of that particular command. In summary, only php 5.3's > buildconf will be run with PHP_AUTOCONF=autoconf-2.13. Yeah.. Felipe mentioned it on IRC. The syntax just seemed wrong within a long script, but when I noticed it was in a context of a shell script it made sense ofcourse :) -Hannes