svn: /web/php-bugs/trunk/ include/functions.php include/query.php scripts/cron/email-assigned www/bug.php www/stats.php

bjori Tue, 30 Aug 2011 14:17:02 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=315785 Log: There is no such status anymore, its a bug type Changed paths: U web/php-bugs/trunk/include/functions.php U web/php-bugs/trunk/include/query.php U web/php-bugs/trunk/scripts/cron/email-assigned U web/php-bugs/trunk/www/bug.php U web/php-bugs/trunk/www/stats.php Modified: web/php-bugs/trunk/include/functions.php =================================================================== --- web/php-bugs/trunk/include/functions.php 2011-08-30 14:01:35 UTC (rev 315784) +++ web/php-bugs/trunk/include/functions.php 2011-08-30 14:17:02 UTC (rev 315785) @@ -24,7 +24,6 @@ 'Closed' => 'Csd', 'Spam' => 'Spm', 'Re-Opened' => 'ReO', - 'To be documented' => 'Tbd', ); $bug_types = array( @@ -53,7 +52,6 @@ 'Stale' => 0, 'Fresh' => 0, 'Bogus' => 1, - 'To be documented' => 1, 'Spam' => 1, 'All' => 0, ); Modified: web/php-bugs/trunk/include/query.php =================================================================== --- web/php-bugs/trunk/include/query.php 2011-08-30 14:01:35 UTC (rev 315784) +++ web/php-bugs/trunk/include/query.php 2011-08-30 14:17:02 UTC (rev 315785) @@ -108,7 +108,6 @@ case 'No Feedback': case 'Feedback': case 'Bogus': - case 'To be documented': $where_clause .= " AND bugdb.status='$status'"; break; case 'Old Feedback': @@ -131,7 +130,7 @@ break; default: case 'Open': - $where_clause .= " AND bugdb.status IN ('Open', 'Re-Opened', 'Assigned', 'Analyzed', 'Critical', 'Verified', 'To be documented')"; + $where_clause .= " AND bugdb.status IN ('Open', 'Re-Opened', 'Assigned', 'Analyzed', 'Critical', 'Verified')"; } if ($search_for != '') { Modified: web/php-bugs/trunk/scripts/cron/email-assigned =================================================================== --- web/php-bugs/trunk/scripts/cron/email-assigned 2011-08-30 14:01:35 UTC (rev 315784) +++ web/php-bugs/trunk/scripts/cron/email-assigned 2011-08-30 14:17:02 UTC (rev 315785) @@ -11,7 +11,7 @@ $sql = "SELECT id, package_name, bug_type, sdesc, status, assign, UNIX_TIMESTAMP(ts1) AS ts_opened, UNIX_TIMESTAMP(ts2) AS ts_changed FROM bugdb WHERE length(assign) > 1 - AND status IN ('Assigned', 'Open', 'Re-Opened', 'Feedback', 'Analyzed', 'Verified', 'Critical', 'Suspended', 'To be documented') + AND status IN ('Assigned', 'Open', 'Re-Opened', 'Feedback', 'Analyzed', 'Verified', 'Critical', 'Suspended') ORDER BY id"; $res = $dbh->query($sql); Modified: web/php-bugs/trunk/www/bug.php =================================================================== --- web/php-bugs/trunk/www/bug.php 2011-08-30 14:01:35 UTC (rev 315784) +++ web/php-bugs/trunk/www/bug.php 2011-08-30 14:17:02 UTC (rev 315785) @@ -406,19 +406,6 @@ strlen(trim($ncomment)) == 0 ) { $errors[] = "You must provide a comment when marking a bug 'Bogus'"; - } elseif (($_POST['in']['status'] == 'To be documented' && $bug['status'] != $_POST['in']['status']) || - (!empty($_POST['in']['resolve']) && $RESOLVE_REASONS[$_POST['in']['resolve']]['status'] == 'To be documented') - ) { - // Require explanation - if (strlen(trim($ncomment)) == 0) { - $errors[] = "You must provide a comment to help in the feature/issue documentation"; - } else if ($bug['status'] != 'To be documented' && $bug['assign'] == $_POST['in']['assign']) { - // Reset the assigned value when changing the status to 'To be documented', - // as more probably the developer (which was marked as assigned) won't document - // the fix. - $_POST['in']['assign'] = ''; - } - $_POST['in']['status'] = 'To be documented'; } elseif (!empty($_POST['in']['resolve'])) { if (!$trytoforce && isset($RESOLVE_REASONS[$_POST['in']['resolve']]) && $RESOLVE_REASONS[$_POST['in']['resolve']]['status'] == $bug['status']) @@ -428,9 +415,7 @@ if ($_POST['in']['status'] == $bug['status']) { $_POST['in']['status'] = $RESOLVE_REASONS[$_POST['in']['resolve']]['status']; } - if ($_POST['in']['status'] == 'Closed' && $bug['status'] == 'To be documented') { - $reason = $FIX_VARIATIONS['fixed']['Documentation problem']; - } elseif (isset($FIX_VARIATIONS) && isset($FIX_VARIATIONS[$_POST['in']['resolve']][$bug['package_name']])) { + if (isset($FIX_VARIATIONS) && isset($FIX_VARIATIONS[$_POST['in']['resolve']][$bug['package_name']])) { $reason = $FIX_VARIATIONS[$_POST['in']['resolve']][$bug['package_name']]; } else { $reason = isset($RESOLVE_REASONS[$_POST['in']['resolve']]) ? $RESOLVE_REASONS[$_POST['in']['resolve']]['message'] : ''; Modified: web/php-bugs/trunk/www/stats.php =================================================================== --- web/php-bugs/trunk/www/stats.php 2011-08-30 14:01:35 UTC (rev 315784) +++ web/php-bugs/trunk/www/stats.php 2011-08-30 14:17:02 UTC (rev 315785) @@ -20,7 +20,6 @@ 'Bogus' => 'Bogus', 'Duplicate' => 'Dupe', 'Wont fix' => 'Wont Fix', - 'To be documented' => 'Tbd', ); $rev = isset($_GET['rev']) ? $_GET['rev'] : 1;