Bug #55711 [Opn]: Report a bug with #sections are reported as %23section

Edit report at https://bugs.php.net/bug.php?id=55711&edit=1 ID: 55711 Updated by: rquadling@php.net Reported by: RQuadling at GMail dot com Summary: Report a bug with #sections are reported as %23section Status: Open Type: Bug Package: Website problem Operating System: n/a PHP Version: Irrelevant Block user comment: N Private report: N New Comment: Damn. And Doh! The # is now turning the id into a URL fragment and doesn't transmit that to the server. So, %23 is going to have to be OK, but it needs to be decoded within bugs.php.net to allow (for example) https://bugs.php.net/report.php? bug_type=Documentation+problem&manpage=function.bcompiler-load-exe#refsect1- function.bcompiler-load-exe-parameters to pass the issue being linked to (in this example) the parameters. But, at the moment, the links that get supplied to bugs.php.net are valid, just without the #fragment. Bug is 50% fixed. Previous Comments: ------------------------------------------------------------------------ [2011-09-16 17:11:58] bjori@php.net Ahh. you are right. According to the PhD release notes[1], as of PhD 1.1.0, refsect1 gets a generated ID if it doesn't contain one :) [1] http://doc.php.net/phd/ ------------------------------------------------------------------------ [2011-09-16 14:53:59] rquadling@php.net Automatic comment from SVN on behalf of rquadling Revision: http://svn.php.net/viewvc/?view=revision&revision=316855 Log: Fix bug#55711 Use the id of the "Report a bug" section rather than the translated text. Use # rather than %23 in the link. ------------------------------------------------------------------------ [2011-09-16 14:49:04] rquadling@php.net As "Report a bug" is added to all .refsect1 h3.title, I'd be surprised if there were any instances where the section didn't have an ID. I've just done a check, looking for all uses of a refsect1 where there is no id on the same line in the rendered HTML (en only). Of the 11,272 files created, only 1 has a line with refsect1 and no id=. The CSS file. So, it looks like the JS code should be OK. And I do have karma - just checked. ------------------------------------------------------------------------ [2011-09-16 14:31:14] bjori@php.net It doesn't necessarily have an ID, the idea of the text after the hash was simply to specify the precise section. When browsing the translated manual, that text will be in the translated language - but I think that is fine as the bug report would probably be against that language anyway. As for the %23 vs #, I've no idea why it is %23 but I'm pretty sure it used to work. Seems like a bug though. Don't you have webkarma already? ------------------------------------------------------------------------ [2011-09-16 14:20:27] RQuadling at GMail dot com Description: ------------ In the non beta documentation, there is an option to "Report a bug", linked to each major section (.refsect1 h3.title). The bug https://bugs.php.net/bug.php?id=55698 reports the page with the problem is http://www.php.net/function.ftp-fget%23Exemples and not http://www.php.net/function.ftp-fget#refsect1-function.ftp-fget-examples This is, I think, 2 bugs. 1 - http://svn.php.net/viewvc/web/php/trunk/include/shared-manual.inc? view=markup#l133 is using ... $(this).text() rather than the id of the parent node. $(this).parent().attr('id') So, in the case of a foreign language bug, the link, as in the example above, refers to a translated text (Exemples) rather than the non translated id (refsect1-function.ftp-fget-examples) 2 - The same line uses %23 rather than #. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55711&edit=1