Re: Bug #60619 [NEW]: Create static version of quickref.php

Thanks Stewart, I've not looked into all of the possibilities (like the JSON you suggest) but the main issue/worry is that calling quickref.php directly requires too many resources. I'll look into this over the coming week, because I'll have the time to do so. It appears your code could replace parts of both quickref.php and manual-lookup.php so this is good. Regards, Philip On Dec 29, 2011, at 7:50 PM, Stewart Lord wrote: > Hi Philip, > > Looks like my change was against manual-lookup.php and not quickref.php (although they are > quite similar). You can see my code here: > > http://pastebin.com/QKnUZUW5 > > The relevant functions are search_manual() and get_function_index() with the latter doing the > caching. > > ...But, a better solution might be to take advantage of the JSON file that is already being > written to /manual/[lang]/search-index.json. I believe it has everything quickref needs. > > Stew > > > On 2011-12-28, at 8:36 PM, Philip Olson wrote: > >> Hi Stewart, >> >> Please do, and feel free to commit to both branches. That'd be great :) >> >> Regards, >> Philip >> >> On Dec 28, 2011, at 3:45 PM, Stewart Lord wrote: >> >>> Hi Philip, I created a caching version of this script a long time ago. Let me know if >>> you are interested and I'll see if I can dig up the code. >>> >>> Stew >>> >>> >>> On 2011-12-28, at 11:52 AM, "philip@php.net"<php-bugs@lists.php.net> >>> wrote: >>> >>>> From: philip >>>> Operating system: Irrelevant >>>> PHP version: Irrelevant >>>> Package: Website problem >>>> Bug Type: Bug >>>> Bug description:Create static version of quickref.php >>>> >>>> Description: >>>> ------------ >>>> The current quickref.php is a resource hog. It is called by either: >>>> >>>> A) included by manual-lookup.php >>>> B) directly >>>> >>>> Calling it directly should utilize a static version of said results, as >>>> they do >>>> not change. This can be weekly when the PHP manual is pushed. >>>> >>>> It could be generated after systems/gen-phpweb-sqlite-db.php is called. >>>> >>>> >>>> -- >>>> Edit bug report at >>>> https://bugs.php.net/bug.php?id=60619&edit=1 >>>> -- >>>> Try a snapshot (PHP 5.4): >>>> https://bugs.php.net/fix.php?id=60619&r=trysnapshot54 >>>> Try a snapshot (PHP 5.3): >>>> https://bugs.php.net/fix.php?id=60619&r=trysnapshot53 >>>> Try a snapshot (trunk): >>>> https://bugs.php.net/fix.php?id=60619&r=trysnapshottrunk >>>> Fixed in SVN: >>>> https://bugs.php.net/fix.php?id=60619&r=fixed >>>> Fixed in SVN and need be documented: >>>> https://bugs.php.net/fix.php?id=60619&r=needdocs >>>> Fixed in release: æ~þŸn± >>>> TtùÙ5—šöhttps://bugs.php.net/fix.php?id=60619&r=alreadyfixed >>>> Need backtrace: >>>> https://bugs.php.net/fix.php?id=60619&r=needtrace >>>> Need Reproduce Script: Vó >>>> UŒöáú 9&³Âhttps://bugs.php.net/fix.php?id=60619&r=needscript >>>> Try newer version: >>>> https://bugs.php.net/fix.php?id=60619&r=oldversion >>>> Not developer issue: >>>> https://bugs.php.net/fix.php?id=60619&r=support >>>> Expected behavior: >>>> https://bugs.php.net/fix.php?id=60619&r=notwrong >>>> Not enough info: >>>> https://bugs.php.net/fix.php?id=60619&r=notenoughinfo >>>> Submitted twice: >>>> https://bugs.php.net/fix.php?id=60619&r=submittedtwice >>>> register_globals: >>>> https://bugs.php.net/fix.php?id=60619&r=globals >>>> PHP 4 support discontinued: >>>> https://bugs.php.net/fix.php?id=60619&r=php4 >>>> Daylight Savings: >>>> https://bugs.php.net/fix.php?id=60619&r=dst >>>> IIS Stability: >>>> https://bugs.php.net/fix.php?id=60619&r=isapi >>>> Install GNU Sed: >>>> https://bugs.php.net/fix.php?id=60619&r=gnused >>>> Floating point limitations: >>>> https://bugs.php.net/fix.php?id=60619&r=float >>>> No Zend Extensions: >>>> https://bugs.php.net/fix.php?id=60619&r=nozend >>>> MySQL Configuration Error: >>>> https://bugs.php.net/fix.php?id=60619&r=mysqlcfg >>>> >>>> >>>> -- >>>> PHP Webmaster List Mailing List (http://www.php.net/) >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>> >>> -- >>> PHP Webmaster List Mailing List (http://www.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >