Re: com web/master: Link to the phpinfo() page: include/functions.inc

On Thu, Apr 19, 2012 at 00:42, Philip Olson <philip@roshambo.org> wrote: > > On Apr 18, 2012, at 3:32 PM, Hannes Magnusson wrote: > >> On Thu, Apr 19, 2012 at 00:27, Philip Olson <philip@php.net> wrote: >>> Commit:    c980e8d93aae0f84cfea252bfbe4dd1932766122 >>> Author:    Philip Olson <philip@php.net>         Wed, 18 Apr 2012 15:27:54 >>> -0700 >>> Parents:   5ebc974d4f01bab1fbc227029645edaa6e229e1f >>> Branches:  master >>> >>> Link:       >>> http://git.php.net/?p=web/master.git;a=commitdiff;h=c980e8d93aae0f84cfea252bfbe4dd1932766122 >>> >>> Log: >>> Link to the phpinfo() page >>> >>> Changed paths: >>>  M  include/functions.inc >>> >>> >>> Diff: >>> diff --git a/include/functions.inc b/include/functions.inc >>> index 2c88497..70f4287 100644 >>> --- a/include/functions.inc >>> +++ b/include/functions.inc >>> @@ -34,6 +34,7 @@ function head($title="") { >>>     <li><a >>> href="/manage/mirrors.php">Mirrors</a></li> >>>     <li><a href="/manage/users.php">Users</a></li> >>>     <li><a >>> href="/manage/user-notes.php">Notes</a></li> >>> +    <li><a >>> href="/manage/pinfo.php">phpinfo()</a></li> >> >> Thats.. Not a good idea. Only handful of people actually can view that >> page. Why annoy everyone else with the link? > > Hrm, good point. Despite being the author of pinfo.php long ago, I > assumed everyone could view it but now see is_mirror_site_admin() > in there. Thanks for the peer review, I'll revert. Moving the function to this file, and check if you can access it before printing the link makes sense. > It can be frustrating to manually type in URLs on master because > there isn't a nice default page, and instead a lot of redirecting > to nothingness. Creating said default page, well, maybe someone > will do that. :) Thats a different, and valid, issue.. I don't think we even have one link to /forgot.php :] -Hannes