Re: com web/php: Halfed the scroll time for TOC comments. It caused a stutter in the scroll on many pages. The faster scroll seems to eliminate the
problem.: js/common.js
| From: | Paul Dragoonis | Date: | Mon, 11 Jun 2012 21:57:15 +0000 |
| Subject: | Re: com web/php: Halfed the scroll time for TOC comments. It caused a stutter in the scroll on many pages. The faster scroll seems to eliminate the problem.: js/common.js |
||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-13679@lists.php.net to get a copy of this message | ||
You should consider adding something like this, it's when things are
in mid-scroll animation and you can cancel it by using mousewheel.
function stopAnimatedScroll(){
if ( $('*:animated').length > 0 ) { $('*:animated').stop(); }
}
if(window.addEventListener) {
document.addEventListener('DOMMouseScroll', stopAnimatedScroll, false);
}
document.onmousewheel = stopAnimatedScroll;
Thanks,
Paul.
On Mon, Jun 11, 2012 at 10:44 PM, Levi Morrison <morrison.levi@gmail.com> wrote:
> The commit message should have read: Halfed the scroll time for TOC links..
>
> On Mon, Jun 11, 2012 at 3:43 PM, Levi Morrison <levim@php.net> wrote:
>
>> Commit: b6894f931a5f0dc4a11abfcc1d3e2c2d3dedbfbf
>> Author: Levi Morrison <levim@php.net> Mon, 11 Jun 2012
>> 15:43:27 -0600
>> Parents: 6dae2828befc5358da8c6dd559776955eb9cb23c
>> Branches: master
>>
>> Link:
>>
>> http://git.php.net/?p=web/php.git;a=commitdiff;h=b6894f931a5f0dc4a11abfcc1d3e2c2d3dedbfbf
>>
>> Log:
>> Halfed the scroll time for TOC comments. It caused a stutter in the
>> scroll on many pages. The faster scroll seems to eliminate the problem.
>>
>> Changed paths:
>> M js/common.js
>>
>>
>> Diff:
>> diff --git a/js/common.js b/js/common.js
>> index c0e4533..79f236a 100644
>> --- a/js/common.js
>> +++ b/js/common.js
>> @@ -219,7 +219,7 @@ $(document).ready(function() {
>> jQuery.getScript("/js/jquery.scrollto.min.js", function(){
>> l.delegate("a.toc_item","click keypress",
>> function(e) {
>> // Escape dots in ids so they won't be treated as
>> class selectors
>> -
>> $.scrollTo($(this).attr("href")..replace(".", "\\\."),
>> 800);
>> +
>> $.scrollTo($(this).attr("href")..replace(".", "\\\."),
>> 400);
>> });
>> });
>>
>>
>> --
>> PHP Webmaster List Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>