Re: Docbook Error
| From: | Kris Craig | Date: | Fri, 20 Jul 2012 23:13:32 +0000 |
| Subject: | Re: Docbook Error | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.doc php.webmaster |
| Request: | Send a blank email to php-webmaster+get-13977@lists.php.net to get a copy of this message | ||
Thanks, Yannick!
--Kris
On Fri, Jul 20, 2012 at 4:09 PM, Yannick Torrès <yannick.torres@gmail.com>wrote:
> I just validate your explode() example via the online editor.
>
> http://svn.php.net/viewvc?view=revision&revision=326752
>
> Best,
> Yannick
>
>
> 2012/7/20 Kris Craig <kris.craig@gmail.com>
>
>>
>>
>> On Fri, Jul 20, 2012 at 12:45 PM, Hannes Magnusson <
>> hannes.magnusson@gmail.com> wrote:
>>
>>> On Fri, Jul 20, 2012 at 8:37 PM, Kris Craig <kris.craig@gmail.com>
>>> wrote:
>>> >
>>> >
>>> > On Fri, Jul 20, 2012 at 12:25 PM, Hannes Magnusson
>>> > <hannes.magnusson@gmail.com> wrote:
>>> >>
>>> >> On Fri, Jul 20, 2012 at 8:14 PM, Kris Craig <kris.craig@gmail.com>
>>> wrote:
>>> >> >
>>> >> >
>>> >> > On Fri, Jul 20, 2012 at 12:02 PM, Hannes Magnusson
>>> >> > <hannes.magnusson@gmail.com> wrote:
>>> >> >>>>
>>> >> >> > And yes I've had the account since 2010. It's all on
>>> >> >> > the list.
>>> And
>>> >> >> > I
>>> >> >> > do
>>> >> >>
>>> >> >> I know you requested an account on August 9th 2010, and later
>>> followed
>>> >> >> it up in September and again in October.
>>> >> >
>>> >> >
>>> >> > As I recall, actually, I only followed-up once. But I could be
>>> >> > mistaken; it
>>> >> > was two years ago, after all.
>>> >>
>>> >> That is why we have archives:
>>> >>
>>> >> http://php.markmail.org/thread/jueltca2ssd7ujmw
>>> >>
>>>
>>> ^^^^^ Click this link
>>>
>>>
>>> [...]
>>> >> >
>>> >> > Ok, so should I contact Philip or do you have time to take care of
>>> this?
>>> >>
>>> >>
>>> >> I want you to show us a patch, just like anyone else, before we grant
>>> >> you any karma.
>>> >>
>>> >> -Hannes
>>> >
>>> >
>>> > Ugh.... If I'd known this wasn't already setup, I'd have thrown
>>> together a
>>> > patch and sent it out two years ago. Somebody did email me directly
>>> but I
>>> > don't remember whom; I'll have to go back and find out.
>>>
>>> Would be fun if you could look up who sent you that mail.
>>>
>>
>> I will. I'm at work right now. ;)
>>
>>
>>>
>>>
>>> > Would you prefer a doc patch or a code patch, or does it matter? Come
>>> to
>>>
>>> Depends on the repository you want access to.
>>> If you want access to commit docs; doc patch.
>>
>>
>>
>>
>>>
>>> > think of it, I'm pretty sure I sent a code patch for including seasonal
>>> > calculations in the date() function back in 2010 (either as part of the
>>> > original request or subsequently, I'm not sure). Can you find it? If
>>> so,
>>> > why was that patch not sufficient? Was it simply overlooked or did I
>>> do
>>> > something wrong?
>>>
>>> Yes, I can find it. Did you not click the link? (See also "click here"
>>> just above).
>>>
>>
>> I'm at work so I'll have to look at it later.
>>
>>
>>>
>>> That patch was never committed. I don't know why it wasn't committed.
>>>
>>
>> I'm not sure, either. Derrick seemed very interested in the idea at the
>> time but then I lost touch with him. I later discovered that, due to a
>> lack of precision in the compiler, the seasonal calculations were being
>> thrown off by a few minutes, which to me is unacceptable because a few
>> minutes can be enough to throw off the day if it's close to midnight.
>> Getting around that has been one of the items on my TODO list for awhile.
>> One option that comes to mind would be using bcmath, but that would
>> involve adding a dependency to one extension that's already required by
>> another extension, which wouldn't be ideal for a number of reasons.
>> Another option would be to find a place to do this other than date(); at
>> this point, I realized I'd need to do some brainstorming on Internals. But
>> again, it's been on the backburner anyway.
>>
>>
>>>
>>>
>>> That patch is not sufficient because there is absolutely no need for
>>> an VCS account, or karma for that matter, to commit one patch.
>>> To get karma we want several patches and "approven interest in
>>> continuing contributions".
>>>
>>> We have dozens of people who can commit drive-by patches.
>>>
>>
>> I think I've demonstrated the interest part over the past two years.
>> What's been lacking is actually putting my money where my mouth is lol
>> (i.e. the actual patches). Once I get setup, I can send you some. How
>> many would be necessary to send in order to cut out this "middle-man"
>> gatekeeper?
>>
>> --Kris
>>
>>
>