com web/master: Should be using filter_var(), not f ilter_input(); adjusts mirrors.php to work with change.: include/functions.inc manage/mirrors
.php

Commit: 19a809e66b859510b191a296bea9fe5104fc6bb0 Author: Daniel P. Brown <danbrown@php.net> Mon, 1 Oct 2012 10:44:25 -0400 Parents: 6467b4aab174a3af99155baf903065a1c449b1bd Branches: master Link: http://git.php.net/?p=web/master.git;a=commitdiff;h=19a809e66b859510b191a296bea9fe5104fc6bb0 Log: Should be using filter_var(), not filter_input(); adjusts mirrors.php to work with change. Changed paths: M include/functions.inc M manage/mirrors.php Diff: diff --git a/include/functions.inc b/include/functions.inc index 01db823..74c0571 100644 --- a/include/functions.inc +++ b/include/functions.inc @@ -208,6 +208,6 @@ function get_ssh_keys($string) { return $results; } -function unmangle($var_name,$filter_type=INPUT_POST,$filter_id=FILTER_UNSAFE_RAW) { - return real_clean(filter_input($filter_type,$var_name,$filter_id)); +function unmangle($var_name,$filter_id=FILTER_UNSAFE_RAW) { + return real_clean(filter_var($var_name,$filter_id)); } diff --git a/manage/mirrors.php b/manage/mirrors.php index cf433c1..9dfb0f4 100644 --- a/manage/mirrors.php +++ b/manage/mirrors.php @@ -58,11 +58,11 @@ if (isset($id) && isset($hostname)) { case "update": $mod_by_time = '<b>'.strtoupper(date('d-M-Y H:i:s T')).'</b> ['.$user.'] Mirror updated'; $query = "UPDATE mirrors SET hostname='$hostname', active=$active, " . - "mirrortype=$mirrortype, cname='$cname', maintainer='".unmangle('maintainer')."', " . - "providername='".unmangle('providername')."', providerurl='$providerurl', " . + "mirrortype=$mirrortype, cname='$cname', maintainer='".unmangle($maintainer)."', " . + "providername='".unmangle($providername)."', providerurl='$providerurl', " . "cc='$cc', lang='$lang', has_stats=$has_stats, " . - "lastedited=NOW(), acmt='".unmangle('acmt_prev')."==\n" . - $mod_by_time.(isset($acmt) && !empty($acmt) ? ": ".unmangle('acmt') : ".")."' WHERE id = $id"; + "lastedited=NOW(), acmt='".unmangle($acmt_prev)."==\n" . + $mod_by_time.(isset($acmt) && !empty($acmt) ? ": ".unmangle($acmt) : ".")."' WHERE id = $id"; $msg = "$hostname updated"; break; @@ -78,8 +78,8 @@ if (isset($id) && isset($hostname)) { "cname, maintainer, providername, providerurl, cc, " . "lang, has_stats, created, lastedited, acmt) " . "VALUES ('$hostname', $active, $mirrortype, '$cname', " . - "'".unmangle('maintainer')."', '".unmangle('providername')."', '$providerurl', '$cc', " . - "'$lang', $has_stats, NOW(), NOW(), '".unmangle('acmt')."')"; + "'".unmangle($maintainer)."', '".unmangle($providername)."', '$providerurl', '$cc', " . + "'$lang', $has_stats, NOW(), NOW(), '".unmangle($acmt)."')"; $msg = "$hostname added"; break; }