com web/master: Just realized that would only match on maximum-length IPv4s, not minimum or between.: fetch/mirrors.php
| From: | Daniel P. Brown | Date: | Wed, 10 Oct 2012 20:32:22 +0000 |
| Subject: | com web/master: Just realized that would only match on maximum-length IPv4s, not minimum or between.: fetch/mirrors.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-14829@lists.php.net to get a copy of this message | ||
Commit: f3f00c50d6acac71b80c7db996372563634d6009
Author: Daniel P. Brown <danbrown@php.net> Wed, 10 Oct 2012 16:32:22 -0400
Parents: 96092a7c913f1901cb207d9d8bcb73f7ae10c1f1
Branches: master
Link: http://git.php.net/?p=web/master.git;a=commitdiff;h=f3f00c50d6acac71b80c7db996372563634d6009
Log:
Just realized that would only match on maximum-length IPv4s, not minimum or between.
Changed paths:
M fetch/mirrors.php
Diff:
diff --git a/fetch/mirrors.php b/fetch/mirrors.php
index 933ec74..5837965 100644
--- a/fetch/mirrors.php
+++ b/fetch/mirrors.php
@@ -99,7 +99,7 @@ if (@mysql_connect("localhost","nobody","")) {
// round-robin CC base hosts - if the IPv4 is available.
// Note that this will also accept IPv4-mapped IPv6
// addresses like so: 123:4:56:789::abc:def:127.0.0.1
- if (strlen($row['ipv4_addr']) >= 15) {
+ if (strlen($row['ipv4_addr']) >= 7) {
echo ' "'.$row['ipv4_addr'].'" =>
array('.PHP_EOL .
' "'.$row['cc'].'",
"'.$row['providername'].'",
'.$row['has_stats'].','.PHP_EOL .
' "'.$row['providerurl'].'",
'.$row['mirrortype'].',
'.$row['has_search'].','.PHP_EOL .