Re: com web/php: force the account requests to www.php.net: git-php.php
| From: | Ferenc Kovacs | Date: | Mon, 28 Jan 2013 09:36:26 +0000 |
| Subject: | Re: com web/php: force the account requests to www.php.net: git-php.php | ||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-15384@lists.php.net to get a copy of this message | ||
On Mon, Jan 28, 2013 at 9:40 AM, Hannes Magnusson <
hannes.magnusson@gmail.com> wrote:
> On Sun, Jan 27, 2013 at 8:33 PM, Ferenc Kovacs <tyrael@php.net> wrote:
> > Commit: 9a85f9de2b668ad5c3e6b85da74bf846342a52c9
> > Author: Ferenc Kovacs <tyra3l@gmail.com> Mon, 28 Jan 2013
> 02:28:25 +0100
> > Parents: a1f27a235e5964731e5af02d6cd4118ccfb59e2f
> > Branches: master
> >
> > Link:
>
> http://git.php.net/?p=web/php.git;a=commitdiff;h=9a85f9de2b668ad5c3e6b85da74bf846342a52c9
> >
> > Log:
> > force the account requests to www.php.net
> >
> > Changed paths:
> > M git-php.php
> >
> >
> > Diff:
> > diff --git a/git-php.php b/git-php.php
> > index 7a4ac9a..9c9da8f 100644
> > --- a/git-php.php
> > +++ b/git-php.php
> > @@ -5,6 +5,12 @@ include_once $_SERVER['DOCUMENT_ROOT'] .
> '/include/prepend.inc';
> > include_once $_SERVER['DOCUMENT_ROOT'] .
> '/include/email-validation.inc';
> > include_once $_SERVER['DOCUMENT_ROOT'] . '/include/posttohost.inc';
> >
> > +// Force the account requests to www.php.net
> > +if ($MYSITE != "http://www.php.net/" &&
> > $MYSITE != 'http://php.net/') {
> > + header('Location:
> > http://www.php.net/'.$_SERVER['BASE_PAGE']);
>
>
> This will create a nasty endless redirect if we every start supporting
> https.
>
> -Hannes
>
> --
> PHP Webmaster List Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Hi Hannes,
Actually I'm already started working on making our code https friendly, but
I didn't wanted to complicate this patch with that, but I will make sure to
change this before I push the https commits.
Thanks for looking into this!
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu