Re: Re: Possible CSS error
| From: | Hannes Magnusson | Date: | Tue, 29 Jan 2013 07:46:37 +0000 |
| Subject: | Re: Re: Possible CSS error | ||
| References: | 1 2 3 4 5 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-15400@lists.php.net to get a copy of this message | ||
Oki. Pushed.
Thanks
-Hannes
On Tue, Jan 22, 2013 at 1:02 PM, Richard Quadling <rquadling@gmail.com> wrote:
> On 22 January 2013 17:48, Richard Quadling <rquadling@gmail.com> wrote:
>> On 22 January 2013 16:25, Hannes Magnusson <hannes.magnusson@gmail.com> wrote:
>>> That seems a littlebit weird that the path was ../images, have you
>>> checked the history of the file though?
>>>
>>> -Hannes
>>>
>>> On Tue, Jan 15, 2013 at 7:26 AM, Richard Quadling <rquadling@gmail.com> wrote:
>>>> Patch.
>>>>
>>>> ===================================
>>>> styles/theme.css | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/styles/theme.css b/styles/theme.css
>>>> index e5ad3d2..828b410 100755
>>>> --- a/styles/theme.css
>>>> +++ b/styles/theme.css
>>>> @@ -923,14 +923,14 @@ table.standard th.subr {
>>>>
>>>> #layout .cse .gsc-tabHeader.gsc-tabhActive,
>>>> #layout .gsc-tabHeader.gsc-tabhActive {
>>>> - background: white url(../images/sprites.png) no-repeat scroll 100% -25px;
>>>> + background: white url(/images/sprites.png) no-repeat scroll 100% -25px;
>>>> border-bottom: solid 0.25em #669;
>>>> color: black;
>>>> }
>>>>
>>>> #layout .cse .gsc-tabHeader.gsc-tabhInactive,
>>>> #layout .gsc-tabHeader.gsc-tabhInactive {
>>>> - background: white url(../images/sprites.png) no-repeat scroll 100% 5px;
>>>> + background: white url(/images/sprites.png) no-repeat scroll 100% 5px;
>>>> border-bottom: solid 0.25em #99c;
>>>> color: #777;
>>>> }
>>>> ===================================
>>>>
>>>> --
>>>> Richard Quadling
>>>> Twitter : EE : Zend
>>>> @RQuadling : http://e-e.com/M_248814.html :
>>>> http://bit.ly/9O8vFY
>>>>
>>>> --
>>>> PHP Webmaster List Mailing List (http://www.php.net/)
>>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>>
>>
>> Hello Hannes.
>>
>> The commit can be seen at
>>
>> http://git.php.net/?p=web/php.git;a=commitdiff;h=5eb4baaaa11d270e0b8424472d5325865c6d7cb0
>>
>> The comment is "Style Google Custom Search Engine results.".
>>
>> I'm guessing it is just a typo and more than likely, the sprites
>> aren't used. I couldn't easily see if the css entries were used, as I
>> could see an id="layout_1" on the search page, but not an id="layout",
>> so, I don't think these are used.
>>
>> I've included Adam in this post as it is his commit.
>>
>> Hopefully it can be sorted easily.
>>
>> Richard.
>
> And, more importantly, the themes.css isn't used on the page with the
> Google Search Results (again, as far as I can tell!). So really
> doesn't look right.
>
> Maybe the CSS files requested need to change to those used by php.net.
>
> reset.css, theme.css and doc.css are the current ones used by the CHM.
>
> But php.net is currently using site.css, phpnet.css and print.css
>
> I'll give this a go. If this still produce nicely formatted docs in
> the CHM, then this could all be for nothing.
>
> In looking at the /doc-base/scripts/build-chms.php script, there's no
> mention of the CSS files used. I would guess that this is saved in the
> phd-config file which is automatically loaded.
>
> Any news on a windows box/vm yet?
>
> Richard.
> --
> Richard Quadling
> Twitter : @RQuadling
> EE : http://e-e.com/M_248814.html
> Zend : http://bit.ly/9O8vFY