Re: com web/php: [beta] putting elephpants on the homepage only, so that all the images don't get loaded for function lookups since we need those
pages to be as fast loading as possible: include/footer.inc
| From: | Paul Dragoonis | Date: | Wed, 03 Jul 2013 16:52:40 +0000 |
| Subject: | Re: com web/php: [beta] putting elephpants on the homepage only, so that all the images don't get loaded for function lookups since we need those pages to be as fast loading as possible: include/footer.inc |
||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-16200@lists.php.net to get a copy of this message | ||
Caching yes, caching no, caching maybe.
When people want to do function lookups they want speed to be able to look
at the function specs. Elephpant pictures on these types of pages
are unnecessary, it's still ideal for the homepage.
On Wed, Jul 3, 2013 at 5:49 PM, Hannes Magnusson <hannes.magnusson@gmail.com
> wrote:
> They are loaded only once, no?
> The rest should hit the browser cache and everything is fine.
>
> -Hannes
>
>
> On Wed, Jul 3, 2013 at 9:45 AM, Paul Dragoonis <dragoonis@php.net> wrote:
> > Commit: d53ec23d06e508d43592025fd9690ffdd219f844
> > Author: Paul Dragoonis <dragoonis@gmail.com> Wed, 3 Jul 2013
> 17:45:21 +0100
> > Parents: 0a5f5891123b1e7259143257005c96de03db6050
> > Branches: master
> >
> > Link:
>
> http://git.php.net/?p=web/php.git;a=commitdiff;h=d53ec23d06e508d43592025fd9690ffdd219f844
> >
> > Log:
> > [beta] putting elephpants on the homepage only, so that all the images
> don't get loaded for function lookups since we need those pages to be as
> fast loading as possible
> >
> > Changed paths:
> > M include/footer.inc
> >
> >
> > Diff:
> > diff --git a/include/footer.inc b/include/footer.inc
> > index 7e624e0..0dded3f 100644
> > --- a/include/footer.inc
> > +++ b/include/footer.inc
> > @@ -27,7 +27,7 @@
> > <?php
> > // if elephpants enabled, insert placeholder nodes
> > // to be populated with images via javascript.
> > - if (isset($config['elephpants'])) {
> > + if (isset($config['elephpants']) &&
> > $_SERVER['REQUEST_URI'] == '/')
> {
> > print "<div class='elephpants'><div
> > class=images></div></div>";
> > }
> > ?>
> >
> >
> > --
> > PHP Webmaster List Mailing List (http://www.php.net/)
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>