Our javascript code for user-notes is now broken on php.net
| From: | Sherif Ramadan | Date: | Tue, 06 Aug 2013 09:32:15 +0000 |
| Subject: | Our javascript code for user-notes is now broken on php.net | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-16440@lists.php.net to get a copy of this message | ||
It looks like Paul Dragoonis has commited a change to web/php.git that has
broken the javascript code that manages user contributed notes. This
results in voting on user notes to be rendered completely broken.
The following is the error Console output from my browser after attempting
to vote on a user note at php.net:
> Uncaught TypeError: Object #<Object> has no method 'effect'
The following is the resulting git blame:
> grep -R "1.3.2/jquery.min.js" ./*
> ./include/layout.inc:<script src="//
ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js"
type="text/javascript"></script>
> git blame ./include/layout.inc
>
> 4db4b6e3 (Paul Dragoonis 2013-06-21 20:04:55 +0100 364) <script
src="//ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js"
type="text/javascript"></script>
>
git log 4db4b6e3 gives me:
> commit 4db4b6e34c6035ba63a9d7953a49aa5f04ba0de4
> Author: Paul Dragoonis <dragoonis@gmail.com>
> Date: Fri Jun 21 20:04:55 2013 +0100
>
> Fixing HTML validation
The commit diff can be found here
http://git.php.net/?p=web/php.git;a=commitdiff;h=4db4b6e34c6035ba63a9d7953a49aa5f04ba0de4
What ends up happening here is the added javascript gets loaded at the end
after the 1.7.2 jquery library was loaded from here (in
include/shared-manual.inc):
http://git.php.net/?p=web/php.git;a=blob;f=include/shared-manual.inc
Since jQuery < 1.5 does not support returning the jqXHR object from the
$.ajax request, which js/usernotes.js currently requires and depends on
(see
http://git.php.net/?p=web/php.git;a=blob;f=js/usernotes.js;h=83804ea42247b9c4629e2a59660d82374bdf72c0;hb=HEAD),
we have failing javascript code since June.
Paul, can you please fix this and update the jQuery to latest version?
Thanks,
Sherif