com web/rmtools: added comment: client/include/PeclExt.php
| From: | Stephen A. Zarkos | Date: | Thu, 12 Sep 2013 17:41:44 +0000 |
| Subject: | com web/rmtools: added comment: client/include/PeclExt.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-16693@lists.php.net to get a copy of this message | ||
Commit: 064aa8b90013d89b2a26bcf8717df194b4d483dd
Author: Anatol Belski <ab@php.net> Thu, 12 Sep 2013 19:41:44 +0200
Parents: 11f0cc59b39b284a5de91b1c395c7e1d3c018463
Branches: master
Link: http://git.php.net/?p=web/rmtools.git;a=commitdiff;h=064aa8b90013d89b2a26bcf8717df194b4d483dd
Log:
added comment
Changed paths:
M client/include/PeclExt.php
Diff:
diff --git a/client/include/PeclExt.php b/client/include/PeclExt.php
index 15eb4bf..e8947e9 100644
--- a/client/include/PeclExt.php
+++ b/client/include/PeclExt.php
@@ -178,6 +178,8 @@ class PeclExt
throw new \Exception("Unsupported compression");
}
+ /* XXX what if we would look for subdirs containing config.w32? The subdir
+ where the file is has to be the root of the source tree. */
if (file_exists(realpath($tmp_path . '/' . $this->pkg_basename))) {
/* This covers the case when the source is in a subdir within a package,
thats native pecl, git.php.net export too. Github should work too, whereby