Re: com web/php: Fade out user notes with negative votes: js/common.js

On Wed, Dec 4, 2013 at 4:02 AM, Paul Dragoonis <dragoonis@gmail.com> wrote: > Hi Dejan, > > Can you explain what this does from a functionality perspective ? > > Can you get rid of the "bang bang" as some non-JS gurus might get messed > up with it in the future. > > > On Wed, Dec 4, 2013 at 2:53 AM, Dejan Marjanovic <dm@php.net> wrote: > >> Commit: 5bf8f70adc258960802a04e973b23d8d65fe15b3 >> Author: Dejan Marjanovic <dejan.marjanovic@gmail.com> Wed, 4 >> Dec 2013 03:53:07 +0100 >> Parents: 54e5393d960618367cd8e6846ab66dc7898097d9 >> Branches: master >> >> Link: >> võAÓ‡¾£(N• >> U™http://git.php.net/?p=web/php.git;a=commitdiff;h=5bf8f70adc258960802a04e973b23d8d65fe15b3 >> >> Log: >> Fade out user notes with negative votes >> >> Changed paths: >> M js/common.js >> >> >> Diff: >> diff --git a/js/common.js b/js/common.js >> index a077893..814f1a8 100755 >> --- a/js/common.js >> +++ b/js/common.js >> @@ -287,7 +287,22 @@ $(document).ready(function() { >> language: getLanguage(), >> limit: 3 >> }); >> - >> + >> +/* {{{ Negative user notes fade-out */ >> + if (!!document.getElementById('usernotes')) >> + { >> + $('.note .tally:contains("-")').each(function(){ >> + var id = this.id.replace('V', ''); >> + >> + var v = this.innerHTML.toInt(); >> + v += 6; >> + v = v <= 2 ? 2 : v; >> + >> + $('#' + id).css('opacity', '0.' + v); >> + }); >> + } >> +/* }}} */ >> + >> }); >> >> /** >> >> >> -- >> PHP Webmaster List Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > Hi Paul, I've added some logic to it: https://github.com/php/web-php/commit/9c118193b50e8e2ea076b3f29c7db54d409e75c8 Obfuscating code/logic doesn't make a guru, that wasn't my intent, I just wrote quick working version :) I suggested it in #php.doc and idea got approved by bjori. It simply fades out negative vote notes.