Re: com web/php: Remove <base> tag completely: include/header.inc
| From: | Hannes Magnusson | Date: | Wed, 04 Dec 2013 19:04:44 +0000 |
| Subject: | Re: com web/php: Remove <base> tag completely: include/header.inc | ||
| References: | 1 2 3 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-17359@lists.php.net to get a copy of this message | ||
Sorry.. I already reverted.
But the base needs to be there, unless you have a fix that fixes all
the manpage shortcuts for example.
-Hannes
On Wed, Dec 4, 2013 at 11:02 AM, Dejan Marjanovic <dm@php.net> wrote:
>
> On Wed, Dec 4, 2013 at 7:59 PM, Hannes Magnusson
> <hannes.magnusson@gmail.com> wrote:
>>
>> No, please revert. This will break tons.
>>
>> -Hannes
>>
>>
>> On Wed, Dec 4, 2013 at 10:39 AM, Dejan Marjanovic <dm@php.net> wrote:
>> > Commit: f6d5200c75c51ae9eafda4fc93e5cb24e87f205e
>> > Author: Dejan Marjanovic <dejan.marjanovic@gmail.com> Wed, 4
>> > Dec 2013 19:39:01 +0100
>> > Parents: 7ab7b50ac40b4f17b8a9ed392ac0bcf2f94621ee
>> > Branches: master
>> >
>> > Link:
>> >
>> > http://git.php.net/?p=web/php.git;a=commitdiff;h=f6d5200c75c51ae9eafda4fc93e5cb24e87f205e
së2_
>> > N�t�4ÁFü
>> >
>> > Log:
>> > Remove <base> tag completely
>> >
>> > Changed paths:
>> > M include/header.inc
>> >
>> >
>> > Diff:
>> > diff --git a/include/header.inc b/include/header.inc
>> > index d65cd03..bb0ba9b 100755
>> > --- a/include/header.inc
>> > +++ b/include/header.inc
>> > @@ -65,8 +65,6 @@ if (isset($shortname) && $shortname) {
>> > <script type="text/javascript" src="<?php echo $STATIC_ROOT
>> > ?>js/ext/html5.js"></script>
>> > <![endif]-->
>> >
>> > - <base href="http://<?php echo
>> > $_SERVER["HTTP_HOST"] .
>> > $_SERVER["SCRIPT_NAME"] ?>">
>> > -
>> > <?php
>> > $jsfiles = array('ext/modernizr.js');
>> > foreach ($jsfiles as $filename) {
>> >
>> >
>> > --
>> > PHP Webmaster List Mailing List (http://www.php.net/)
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>> >
>
>
> I removed to push as fast as possible because I messed up, Opera works now
> but I'm re-adding the base. Sorry for that.