com web/php: Move that stat to the bottom, and inline the uservoice: include/footer.inc include/uservoice.inc
| From: | Hannes Magnusson | Date: | Wed, 04 Dec 2013 21:56:34 +0000 |
| Subject: | com web/php: Move that stat to the bottom, and inline the uservoice: include/footer.inc include/uservoice.inc | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-17367@lists.php.net to get a copy of this message | ||
Commit: 3821012af323b217abbfb46c2a20d7ed6b64f5cf
Author: Hannes Magnusson <bjori@mongodb.com> Wed, 4 Dec 2013 13:56:34 -0800
Parents: 25a38fd4a3fc448b37e94ea4b5fb117e1bde1ad5
Branches: master
Link: http://git.php.net/?p=web/php.git;a=commitdiff;h=3821012af323b217abbfb46c2a20d7ed6b64f5cf
Log:
Move that stat to the bottom, and inline the uservoice
Changed paths:
M include/footer.inc
D include/uservoice.inc
Diff:
diff --git a/include/footer.inc b/include/footer.inc
index 8c49e17..db2545b 100644
--- a/include/footer.inc
+++ b/include/footer.inc
@@ -42,6 +42,21 @@
}
?>
+ <!-- External and third party libraries. -->
+ <script type="text/javascript"
src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
+ <script type="text/javascript"
src="/cached.php?f=/js/ext/hogan-2.0.0.min.js&t=2"></script>
+ <script type="text/javascript"
src="/cached.php?f=/js/ext/typeahead.min.js&t=2"></script>
+
+ <?php
+ // Nick bjori's last modified code for our own JS files.
+ $jsfiles = array('search.js', 'common.js');
+ foreach ($jsfiles as $filename) {
+ $path = dirname(dirname(__FILE__)).'/js/'.$filename;
+ echo '<script type="text/javascript"
src="/cached.php?f=/js/'.$filename.'&t='.@filemtime($path).'"></script>',
PHP_EOL;
+ }
+ ?>
+
+<!-- GoSquared stats -->
<script type="text/javascript">
var GoSquared = {};
GoSquared.acct = "GSN-094556-T";
@@ -60,21 +75,24 @@
})(window);
</script>
- <!-- External and third party libraries. -->
- <script type="text/javascript"
src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
- <script type="text/javascript"
src="/cached.php?f=/js/ext/hogan-2.0.0.min.js&t=2"></script>
- <script type="text/javascript"
src="/cached.php?f=/js/ext/typeahead.min.js&t=2"></script>
-
- <?php
- // Nick bjori's last modified code for our own JS files.
- $jsfiles = array('search.js', 'common.js');
- foreach ($jsfiles as $filename) {
- $path = dirname(dirname(__FILE__)).'/js/'.$filename;
- echo '<script type="text/javascript"
src="/cached.php?f=/js/'.$filename.'&t='.@filemtime($path).'"></script>',
PHP_EOL;
- }
+<!-- UserVoice JavaScript SDK (only needed once on a page) -->
+<script>(function(){var
uv=document.createElement('script');uv.type='text/javascript';uv.async=true;uv.src='//widget.uservoice.com/zDo1PI3X0lzE9SaQxC3LQ.js';var
s=document.getElementsByTagName('script')[0];s.parentNode.insertBefore(uv,s)})()</script>
- include 'uservoice.inc';
- ?>
+<!-- A tab to launch the Classic Widget -->
+<script>
+UserVoice = window.UserVoice || [];
+UserVoice.push(['showTab', 'classic_widget', {
+ mode: 'feedback',
+ primary_color: '#9999cc',
+ link_color: '#3f438d',
+ forum_id: 211823,
+ feedback_tab_name: 'Give feedback',
+ tab_label: 'Feedback & Ideas',
+ tab_color: '#666699',
+ tab_position: 'middle-right',
+ tab_inverted: false
+}]);
+</script>
</body>
</html>
diff --git a/include/uservoice.inc b/include/uservoice.inc
deleted file mode 100644
index eaee2b0..0000000
--- a/include/uservoice.inc
+++ /dev/null
@@ -1,18 +0,0 @@
-<!-- UserVoice JavaScript SDK (only needed once on a page) -->
-<script>(function(){var
uv=document.createElement('script');uv.type='text/javascript';uv.async=true;uv.src='//widget.uservoice.com/zDo1PI3X0lzE9SaQxC3LQ.js';var
s=document.getElementsByTagName('script')[0];s.parentNode.insertBefore(uv,s)})()</script>
-
-<!-- A tab to launch the Classic Widget -->
-<script>
-UserVoice = window.UserVoice || [];
-UserVoice.push(['showTab', 'classic_widget', {
- mode: 'feedback',
- primary_color: '#9999cc',
- link_color: '#3f438d',
- forum_id: 211823,
- feedback_tab_name: 'Give feedback',
- tab_label: 'Feedback & Ideas',
- tab_color: '#666699',
- tab_position: 'middle-right',
- tab_inverted: false
-}]);
-</script>
\ No newline at end of file