Re: com web/php: Improved the landing page when adding notes. Also improved legibility of headers. Separated em and strong styles.:
manual/add-note.php styles/theme-base.css styles/theme-medium.css
| From: | Peter Cowburn | Date: | Wed, 11 Dec 2013 08:56:32 +0000 |
| Subject: | Re: com web/php: Improved the landing page when adding notes. Also improved legibility of headers. Separated em and strong styles.: manual/add-note.php styles/theme-base.css styles/theme-medium.css |
||
| References: | 1 2 3 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-17520@lists.php.net to get a copy of this message | ||
On 11 December 2013 03:58, Levi Morrison <morrison.levi@gmail.com> wrote:
> I was fully aware of the impact when I made the commit. Thank you for your
> concern.
Regardless, it's a good idea to make unrelated changes as separate commits.
>
> On Tue, Dec 10, 2013 at 6:37 PM, Hannes Magnusson <
> hannes.magnusson@gmail.com> wrote:
>
> > On Tue, Dec 10, 2013 at 3:06 PM, Levi Morrison <levim@php.net> wrote:
> > > Commit: e505d3062b584d14428fd401ffe74f5e0bdcead9
> > > Author: Levi Morrison <levim@php.net> Tue, 10 Dec 2013
> > 16:06:29 -0700
> > > Parents: dc643c1822ed8b9a37b43b754067ce940981ee7e
> > > Branches: master
> > >
> > > Link:
> >
>
> http://git.php.net/?p=web/php.git;a=commitdiff;h=e505d3062b584d14428fd401ffe74f5e0bdcead9
> > >
> > > Log:
> > > Improved the landing page when adding notes. Also improved legibility
> of
> > headers. Separated em and strong styles.
>
> >
> > > Changed paths:
> > > M manual/add-note.php
> > > M styles/theme-base.css
> > > M styles/theme-medium.css
> > >
> >
> >
> > Splitting changes into multiple commits is generally very good idea.
> >
> > This changed all heading on manual pages for example to become very
> > fatty fatsos and looks a bit out of place.
> >
> > -Hannes
> >
>