Re: Shared code/layout repo

From: Date: Sat, 14 Dec 2013 01:16:47 +0000
Subject: Re: Shared code/layout repo
References: 1 2 3 4  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-17619@lists.php.net to get a copy of this message
On Fri, Dec 13, 2013 at 4:55 PM, Levi Morrison <morrison.levi@gmail.com> wrote: >> I had no intentions of making phpweb use that shared repo at to the >> moment since the that would require significant work as the current >> markup and css is really complex, which none of our other website >> need, and I just didn't see the benefit. > > > Sure, I understand that. What I mean is that I significantly change what the > content boxes and such look like. They are much simpler now and look even > better. I'll try to dig into this more over the weekend. I'd say such changes need to be done incrementally and go through our standard review process... Have you looked at the sites I've already deployed with the repo? I only ported the 1 and 2 column layout: http://people.php.net/user.php?username=levim And simplified the header (and made it slightly thinner in the process) The search box and "secondscreen" column also share the same class so they'll always be in sync. -Hannes

« previous php.webmaster (#17619) next »