Re: com web/php: Fix duplicate flash messages and improve a bit: include/header.inc js/common.js styles/theme-base.css
| From: | Dejan Marjanovic | Date: | Mon, 16 Dec 2013 01:33:31 +0000 |
| Subject: | Re: com web/php: Fix duplicate flash messages and improve a bit: include/header.inc js/common.js styles/theme-base.css | ||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-17661@lists.php.net to get a copy of this message | ||
On Mon, Dec 16, 2013 at 2:13 AM, Hannes Magnusson <
hannes.magnusson@gmail.com> wrote:
> On Sun, Dec 15, 2013 at 2:13 PM, Dejan Marjanovic <dm@php.net> wrote:
> > Commit: 6f0bf1a41a6d0ef56e69b1c60c50d843279c3981
> > Author: Dejan Marjanovic <dejan.marjanovic@gmail.com> Sun,
> 15 Dec 2013 23:13:49 +0100
> > Parents: c2bfb90c016632b2ae5e664f2cfda27cc3f03b69
> > Branches: master
> >
> > Link:
>
> http://git.php.net/?p=web/php.git;a=commitdiff;h=6f0bf1a41a6d0ef56e69b1c60c50d843279c3981
> >
> > Log:
> > Fix duplicate flash messages and improve a bit
> >
> > Changed paths:
> > M include/header.inc
> > M js/common.js
> > M styles/theme-base.css
> >
> >
> > Diff:
> > diff --git a/include/header.inc b/include/header.inc
> > index 8820337..a7e7965 100755
> > --- a/include/header.inc
> > +++ b/include/header.inc
> > @@ -81,7 +81,10 @@ if (isset($shortname) && $shortname) {
> > <input type="search" name="pattern"
> > class="search-query"
> placeholder="Search" accesskey="s">
> > </form>
> > </div>
> > - <div id="flash-message"></div>
> > + <div id="flash-message">
> > + <div data-type="success" class="message">Hello
> > there</div>
> > + <div data-type="error" class="message">Naughty!</div>
> > + </div>
> > </nav>
>
>
> Hehh... this looks like a test code? Should probably be reverted...
>
> -Hannes
>
Hey bjori, I pushed the "Oooops" commit right away :)
Rewritten most of the functionality by now. No revert needed.
<http://php.net>