Re: com web/php: We don't want `'elephpants' => false` to render the elephpants.: include/footer.inc include/shared-manual.inc

On Sun, Dec 15, 2013 at 5:30 PM, Levi Morrison <morrison.levi@gmail.com> wrote: > On Sun, Dec 15, 2013 at 6:12 PM, Hannes Magnusson > <hannes.magnusson@gmail.com> wrote: >> >> On Sun, Dec 15, 2013 at 12:14 PM, Levi Morrison <levim@php.net> wrote: >> > Commit: e5f81e5cc1d458d5c90f6a962a3899951f0992f7 >> > Author: Levi Morrison <levim@php.net> Sun, 15 Dec 2013 >> > 13:14:39 -0700 >> > Parents: ea3a70e9d9ce14482a73d023a0e80fcd05311c84 >> > Branches: master >> > >> > Link: >> > >> > http://git.php.net/?p=web/php.git;a=commitdiff;h=e5f81e5cc1d458d5c90f6a962a3899951f0992f7 >> > >> > Log: >> > We don't want 'elephpants' => false >> > to render the elephpants. >> > >> >> This seems to do more then just add a value check, in fact it removes >> the elephpants ? > > > On many pages, yes. It seems I didn't split that commit up (I thought I > did). Anyway, it was previously implemented that elephpants wouldn't show up > on doc pages, only on the homepage. This is bringing it back into line with > that behavior. Perhaps I missed some discussion or something where we > decided to keep them on all pages? If so I'm sorry. I'm curious of the benefits of removing them? The elephpants are cached very harshly, and their size is less then the size of the fonts loaded - and are on pair with the CSS (and actually smaller then the css files before I compressed them, even after the removal of ~1500 or so lines you did). I think they are misunderstood and preemptively judged and sacrificed without any real reason. -Hannes