Re: com web/bugs: Some code tweaks: include/functions.php

From: Date: Thu, 22 May 2014 05:05:20 +0000
Subject: Re: com web/bugs: Some code tweaks: include/functions.php
References: 1 2 3  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-18958@lists.php.net to get a copy of this message
On Wed, May 21, 2014 at 8:16 PM, Daniel Convissor <danielc@analysisandsolutions.com> wrote: > Hi: > >> Please make sure you change as little WhiteSpace as possible when >> doing other real changes, and vice versa. > > Personally, after years of having made many coding standards cleanup > commits, I have been convinced to _not_ make commits solely for coding > standards. Such changes complicate finding actual changes via "git > blame." Indeed. Which is why you shouldn't do commit just to satisfy a coding style as such commit hurts more then the slight inconsistency it attempted to solve. If you must. Please do it in a separate commit. That makes it easier to skip that specific commit in "git blame" and allows for code review of the commit. Thank you for your kindness, -Hannes

« previous php.webmaster (#18958) next »