Re: com web/bugs: This code was redundant: www/bug.php
| From: | Ferenc Kovacs | Date: | Thu, 12 Jun 2014 19:38:37 +0000 |
| Subject: | Re: com web/bugs: This code was redundant: www/bug.php | ||
| References: | 1 2 3 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-19260@lists.php.net to get a copy of this message | ||
On Thu, Jun 12, 2014 at 9:34 PM, Maciej Sobaczewski <sobak@php.net> wrote:
> On Thu, Jun 12, 2014 at 9:15 PM, <sobak@php.net> wrote:
>>
>> Commit: 1d46b0c35603f42a5e618cd4009d3508a7e97d60
>>> Author: Sobak <msobaczewski@gmail.com> Thu, 12 Jun 2014
>>> 21:15:24 +0200
>>> Parents: 2b13da9454abee46614cc058df3fc03a033eabe8
>>> Branches: master
>>>
>>> Link:
>>> http://git.php.net/?p=web/bugs.git;a=commitdiff;h=
>>> 1d46b0c35603f42a5e618cd4009d3508a7e97d60
>>>
>>> Log:
>>> This code was redundant
>>>
>>> Changed paths:
>>> M www/bug.php
>>>
>>>
>>> Diff:
>>> diff --git a/www/bug.php b/www/bug.php
>>> index 1fb3aa2..1c46c24 100644
>>> --- a/www/bug.php
>>> +++ b/www/bug.php
>>> @@ -172,18 +172,11 @@ $block_user = isset($block_user) ? $block_user :
>>> $bug['block_user_comment'];
>>> $is_private = isset($is_private) ? $is_private : $bug['private'];
>>>
>>> // Handle any updates, displaying errors if there were any
>>> -$RESOLVE_REASONS = $FIX_VARIATIONS = $pseudo_pkgs = array();
>>> -
>>> -$project = $bug['project'];
>>> -
>>> -// Only fetch stuff when it's really needed
>>> -if ($edit && $edit < 3) {
>>> - $pseudo_pkgs = get_pseudo_packages($project, false); // false ==
>>> no read-only packages included
>>> -}
>>> +$RESOLVE_REASONS = $FIX_VARIATIONS = array();
>>>
>>> // Fetch RESOLVE_REASONS array
>>> if ($edit === 1) {
>>> - list($RESOLVE_REASONS, $FIX_VARIATIONS) =
>>> get_resolve_reasons($project);
>>> + list($RESOLVE_REASONS, $FIX_VARIATIONS) =
>>> get_resolve_reasons($bug['project']);
>>> }
>>>
>>> if (isset($_POST['ncomment']) &&
>>> !isset($_POST['preview']) && $edit ==
>>> 3)
>>> {
>>>
>>>
>>> --
>>> PHP Webmaster List Mailing List (http://www.php.net/)
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>>
>>> didn't you just removed the pecl packages from the package list? (pseudo
>> packages).
>>
>>
> It was the only use of this variable in bug.php. I don't know if this
> variable can be "extracted" outside the file of any way and if not, then it
> seems to be unused.
>
>
interesting, we have the PECL exts on the report bug form, but not on the
edit form.
maybe this was always "bugged".
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu