Re: com web/php: Attempt to fix the php.net cross-domain issues once and for all.: include/site.inc
| From: | Hannes Magnusson | Date: | Thu, 03 Jul 2014 15:59:15 +0000 |
| Subject: | Re: com web/php: Attempt to fix the php.net cross-domain issues once and for all.: include/site.inc | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-19390@lists.php.net to get a copy of this message | ||
On Wed, Jul 2, 2014 at 6:17 PM, Adam Harvey <aharvey@php.net> wrote:
> Commit: d89cf4ec47214e5d2494ced23a732a8861695360
> Author: Adam Harvey <aharvey@php.net> Wed, 2 Jul 2014 18:17:31 -0700
> Parents: 5335474af5a3b8d75948b11bc5599d69561494c2
> Branches: master
>
> Link:
> http://git.php.net/?p=web/php.git;a=commitdiff;h=d89cf4ec47214e5d2494ced23a732a8861695360
>
> Log:
> Attempt to fix the php.net cross-domain issues once and for all.
>
> (But this is a terrible hac...)
>
> ONCE AND FOR ALL.
>
> Changed paths:
> M include/site.inc
>
>
> Diff:
> diff --git a/include/site.inc b/include/site.inc
> index 508fd62..affa89d 100644
> --- a/include/site.inc
> +++ b/include/site.inc
> @@ -515,6 +515,10 @@ if($_SERVER["SERVER_PORT"] != '80' &&
> $_SERVER["SERVER_PORT"] != 443) {
> $msite = 'http://' .
> $_SERVER["SERVER_NAME"] . '/';
> }
>
> +// This is a horrendous hack that should be removed at some point, but we need
> +// to avoid cross-domain issues where php.net is configured as www.php.net.
> +$MIRRORS['http://php.net/'] =
> $MIRRORS['http://www.php.net/'];
> +
This breaks our links and will effectively void us from google.com as
we announce http://php.net/.... as our urls.
-Hannes