Re: FW: [PHP-WEBMASTER] [PR][web-php][#49][master][opened] - Add mirror link back in the footer
| From: | Peter Cowburn | Date: | Mon, 18 Aug 2014 17:54:04 +0000 |
| Subject: | Re: FW: [PHP-WEBMASTER] [PR][web-php][#49][master][opened] - Add mirror link back in the footer | ||
| References: | 1 2 3 4 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-19702@lists.php.net to get a copy of this message | ||
On 18 August 2014 18:11, Mark Scholten <mark@streamservice.nl> wrote:
> Hello Hannes,
>
> Regarding this change I didn't see any response anywhere so that is why I
> wanted to know if it was the correct way to propose changes incl. code. It
> was discussed that they should be back and that is why I provided the
> code/pull request.
>
Could you point out that discussion? Guess I missed it.
>
> Regards, Mark
>
Cheers,
Peter “too lazy to trawl the list archives” Cowburn
>
> > -----Original Message-----
> > From: Hannes Magnusson [mailto:hannes.magnusson@gmail.com]
> > Sent: 18 August, 2014 18:57
> > To: Mark Scholten
> > Cc: PHP Webmaster ML
> > Subject: Re: FW: [PHP-WEBMASTER] [PR][web-php][#49][master][opened] -
> > Add mirror link back in the footer
> >
> > Sure. But as you can see, either people are not comfortable with this
> change -
> > and therefore don't merge it - or are against it.
> >
> > There are so many links back to the sponsor that I cannot imagine how
> this is
> > helpful.
> >
> > -Hannes
> >
> >
> > On Mon, Aug 18, 2014 at 8:31 AM, Mark Scholten <mark@streamservice.nl>
> > wrote:
> > > Hello,
> > >
> > > Is using github for pull requests the correct way to get someone to
> check it
> > and when needed/useful to get it included in php.net or is there another
> > option for this to help with the php.net website?
> > >
> > > Regards, Mark
> > >
> > >> -----Original Message-----
> > >> From: noreply@php.net [mailto:noreply@php.net]
> > >> Sent: 31 July, 2014 16:01
> > >> To: php-webmaster@lists.php.net
> > >> Subject: [PHP-WEBMASTER] [PR][web-php][#49][master][opened] - Add
> > >> mirror link back in the footer
> > >>
> > >> You can view the Pull Request on github:
> > >> https://github.com/php/web-php/pull/49
> > >>
> > >> Pull Request Description:
> > >> As it was in the past and as it was agreed on when providing a mirror
> > >> for most sponsors
> > >>
> > >>
> > >> --
> > >> PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe,
> > visit:
> > >> http://www.php.net/unsub.php
> > >
> > >
> > >
> > > --
> > > PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe,
> > > visit: http://www.php.net/unsub.php
> > >
>
>
> --
> PHP Webmaster List Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>