Re: [PATCH] Better handling for deprecated functions (implements #66861)
| From: | Maciej Sobaczewski | Date: | Fri, 06 Mar 2015 18:48:39 +0000 |
| Subject: | Re: [PATCH] Better handling for deprecated functions (implements #66861) | ||
| References: | 1 2 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-20810@lists.php.net to get a copy of this message | ||
Great. I'll fix issues you've mentioned, thanks for the review :) Do we still build manual once a week on Fridays?
Greetings,
Maciej.
W dniu 2015-03-06 o 19:43, Hannes Magnusson pisze:
On Thu, Mar 5, 2015 at 10:12 PM, Maciej Sobaczewski <sobak@php.net> wrote:Hello, some of you probably remember this feature request https://bugs.php.net/bug.php?id=66861 I created working, but not-so-well-tested implementation of this mockup: http://i.imgur.com/EH1d9ew.png Pull requests are ready for review (they are complementary), all details inside: - https://github.com/php/web-php/pull/63 - https://github.com/php/phd/pull/12 I would be very glad for code review and testing in at least one more environment.I haven't tried this but it looks great and brilliant idea. I don't see any synchronization issues either, the phpweb commit can be pushed out days before we push the phd commit without worrying about version matching the backend files and generated files. I made some minor comments on the phd part, but thats about it. -Hannes
