Re: com web/shared: got rid of left margins ofheadings: styles/wiki.css

Levi Morrison wrote: > On Wed, Mar 25, 2015 at 6:16 PM, Christoph Michael Becker <cmb@php.net> wrote: >> Commit: fec014f98d12a11529ce94f90107283469d72fc8 >> Author: Christoph M. Becker <cmbecker69@gmx.de> Thu, 26 Mar 2015 01:16:54 >> +0100 >> Parents: a7802835d7f17cc7234211393c2d11ae214d1290 >> Branches: master >> >> Link: >> http://git.php.net/?p=web/shared.git;a=commitdiff;h=fec014f98d12a11529ce94f90107283469d72fc8 >> >> Log: >> got rid of left margins of headings >> >> Changed paths: >> M styles/wiki.css >> >> >> Diff: >> diff --git a/styles/wiki.css b/styles/wiki.css >> index b519b97..35cc410 100644 >> --- a/styles/wiki.css >> +++ b/styles/wiki.css >> @@ -1013,6 +1013,7 @@ h1, h2, h3, h4, h5, h6 { >> border-bottom:0; >> padding:0; >> color:#793862; >> + margin-left: 0; >> } >> h1:after, >> h2:after, >> >> >> -- >> PHP Webmaster List Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php > > At the time I investigated this change the wiki box was having issues > and was unable to see its impact. I just remembered to review this > change now. > > It looks pretty wonky in RFCs. The headers intentionally had a left > margin to align them with content of that section; here's one example: > > https://wiki.php.net/rfc/remove_php4_constructors#backward_incompatible_changes > > What is the rationale of removing this margin? My rationale was to make the headers stand out -- but after reviewing it now, I have to admit that you're right and that it looks wonky. I have reverted the change. Thanks for pointing out the issue. :) -- Christoph M. Becker