Re: com web/bugs: .: include/classes/bug_patchtracker.php

Rasmus Lerdorf wrote: > Commit: b792953c6004e7a1e62a29ec95bb033217678caa > Author: Rasmus Lerdorf <rasmus@php.net> Sat, 18 Jul 2015 14:35:33 -0700 > Parents: 2ace8a88e5887bdc3119cb12af8e1316fe2206b7 > Branches: master > > Link: > http://git.php.net/?p=web/bugs.git;a=commitdiff;h=b792953c6004e7a1e62a29ec95bb033217678caa > > Log: > . > > Changed paths: > M include/classes/bug_patchtracker.php > > > Diff: > diff --git a/include/classes/bug_patchtracker.php b/include/classes/bug_patchtracker.php > index 772504f..cd77815 100644 > --- a/include/classes/bug_patchtracker.php > +++ b/include/classes/bug_patchtracker.php > @@ -132,7 +132,7 @@ class Bug_Patchtracker > return PEAR::raiseError('Upload directory for patches could not be initialized'); > } > if (!preg_match('/^[\w\-\.]+\z/', $name) || strlen($name) > 80) { > - return PEAR::raiseError("Invalid patch name \"{$name}\""); > + return PEAR::raiseError("Invalid patch name > \"".htmlspecichars($name)."\""); Shouldn't that be htmlspecialchars()? > } > if (!is_array($obsoletes)) { > return PEAR::raiseError('Invalid obsoleted patches'); -- Christoph M. Becker