cvs: php-gcov-web /cron cron.sh
| From: | Nuno Lopes | Date: | Sat, 13 Oct 2007 11:25:18 +0000 |
| Subject: | cvs: php-gcov-web /cron cron.sh | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-239@lists.php.net to get a copy of this message | ||
nlopess Sat Oct 13 11:25:18 2007 UTC
Modified files:
/php-gcov-web/cron cron.sh
Log:
dont trap EXIT or the globalpidile might get removed when it should not (e.g. when the cron script
is called for the 2nd time
http://cvs.php.net/viewvc.cgi/php-gcov-web/cron/cron.sh?r1=1.7&r2=1.8&diff_format=u
Index: php-gcov-web/cron/cron.sh
diff -u php-gcov-web/cron/cron.sh:1.7 php-gcov-web/cron/cron.sh:1.8
--- php-gcov-web/cron/cron.sh:1.7 Tue Oct 2 19:28:39 2007
+++ php-gcov-web/cron/cron.sh Sat Oct 13 11:25:18 2007
@@ -17,20 +17,12 @@
# | Nuno Lopes <nlopess@php.net> |
# +----------------------------------------------------------------------+
-# $Id: cron.sh,v 1.7 2007/10/02 19:28:39 nlopess Exp $
+# $Id: cron.sh,v 1.8 2007/10/13 11:25:18 nlopess Exp $
source ./config.sh
export LC_ALL=C
export CCACHE_DISABLE=1
-# Called either on error or successful completion
-remove_pid_files()
-{
- rm -f "$PIDFILE"
- rm -f "$GLOBALPIDFILE"
-}
-trap remove_pid_files EXIT
-
# the file with the pid of this process
GLOBALPIDFILE="${PHPROOT}/build.pid"
@@ -169,7 +161,7 @@
done
-remove_pid_files
+rm -f "$GLOBALPIDFILE"
# display an error if the tag doesn't exist